fix(findbugs): suppress minor findbug issues

shaobin0604 · May 13, 2019 · 07b4ebd · 07b4ebd
1 parent 1ec44c7
commit 07b4ebd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/phantom-host-lib/src/main/java/com/wlqq/phantom/library/pm/PluginInfo.java b/phantom-host-lib/src/main/java/com/wlqq/phantom/library/pm/PluginInfo.java
@@ -48,6 +48,7 @@
 import com.wlqq.phantom.library.proxy.PluginClassLoader;
 import com.wlqq.phantom.library.proxy.ResourcesProxy;
 import com.wlqq.phantom.library.utils.FileUtils;
+import com.wlqq.phantom.library.utils.SuppressFBWarnings;
 import com.wlqq.phantom.library.utils.TimingUtils;
 import com.wlqq.phantom.library.utils.VLog;
 
@@ -345,6 +346,7 @@ public File getExtraOdexesDir() {
         return getDexDir(PluginManager.EXTRA_ODEX_DIR);
     }
 
+    @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
     private File getDexDir(String dir) {
         File extraDexDir = new File(installDir, dir);
         if (!extraDexDir.exists()) {

diff --git a/phantom-host-lib/src/main/java/com/wlqq/phantom/library/proxy/PluginClassLoader.java b/phantom-host-lib/src/main/java/com/wlqq/phantom/library/proxy/PluginClassLoader.java
@@ -27,6 +27,7 @@
 import com.wlqq.phantom.library.utils.FileUtils;
 import com.wlqq.phantom.library.utils.IoUtils;
 import com.wlqq.phantom.library.utils.ReflectUtils;
+import com.wlqq.phantom.library.utils.SuppressFBWarnings;
 import com.wlqq.phantom.library.utils.VLog;
 
 import java.io.File;
@@ -279,6 +280,7 @@ private static int getSecondaryDexesCount(PluginInfo pi) throws IOException {
         return FileUtils.readFileToInt(getDexesCountFile(pi));
     }
 
+    @SuppressFBWarnings("RV_RETURN_VALUE_IGNORED_BAD_PRACTICE")
     private static void putSecondaryDexesCount(PluginInfo pi, List<File> extractedDexes) {
         final File dexesCountFile = getDexesCountFile(pi);
         try {

diff --git a/phantom-host-lib/src/main/java/com/wlqq/phantom/library/proxy/PluginInterceptActivity.java b/phantom-host-lib/src/main/java/com/wlqq/phantom/library/proxy/PluginInterceptActivity.java
@@ -454,6 +454,7 @@ public View onCreateView(View parent, String name, Context context, AttributeSet
      *
      * @return true使用appcompat-v7主题，false其他主题
      */
+    @SuppressFBWarnings("REC_CATCH_EXCEPTION")
     private boolean useAppCompatTheme() {
         try {
             Class styleCls = mContentProxy.getClassLoader().findClassFast("android.support.v7.appcompat.R$styleable");