Merge pull request #66 from 4lxndr/fix/65-datetime-immutable

Fixes wrong datetime type usage

src/Command/CronRunCommand.php

@@ -4,6 +4,7 @@
 
 namespace Shapecode\Bundle\CronBundle\Command;
 
+use DateTime;
 use Doctrine\ORM\EntityManagerInterface;
 use Psr\Clock\ClockInterface;
 use Shapecode\Bundle\CronBundle\Collection\CronJobRunningCollection;
@@ -43,7 +44,7 @@ public function __construct(
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $style = new CronStyle($input, $output);
-        $now   = $this->clock->now();
+        $now   = DateTime::createFromImmutable($this->clock->now());
 
         $jobsToRun = $this->cronJobRepository->findAll();
 

src/EventListener/EntitySubscriber.php

@@ -4,6 +4,7 @@
 
 namespace Shapecode\Bundle\CronBundle\EventListener;
 
+use DateTime;
 use Doctrine\Bundle\DoctrineBundle\Attribute\AsDoctrineListener;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Events;
@@ -41,7 +42,7 @@ private function setDates(LifecycleEventArgs $args): void
             return;
         }
 
-        $now = $this->clock->now();
+        $now = DateTime::createFromImmutable($this->clock->now());
 
         if ($entity->getCreatedAt() === null) {
             $entity->setCreatedAt($now);

tests/EventListener/EntitySubscriberTest.php

@@ -0,0 +1,86 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Shapecode\Bundle\CronBundle\Tests\EventListener;
+
+use DateTime;
+use DateTimeImmutable;
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\Persistence\Event\LifecycleEventArgs;
+use PHPUnit\Framework\TestCase;
+use Psr\Clock\ClockInterface;
+use Shapecode\Bundle\CronBundle\Entity\AbstractEntity;
+use Shapecode\Bundle\CronBundle\EventListener\EntitySubscriber;
+use stdClass;
+
+class EntitySubscriberTest extends TestCase
+{
+    private ClockInterface $clock;
+
+    private EntitySubscriber $subscriber;
+
+    protected function setUp(): void
+    {
+        $this->clock      = $this->createMock(ClockInterface::class);
+        $this->subscriber = new EntitySubscriber($this->clock);
+    }
+
+    public function testPrePersistSetsCreatedAtAndUpdatedAtWhenNull(): void
+    {
+        $now = new DateTimeImmutable('2024-10-10 12:00:00');
+        $this->clock->method('now')->willReturn($now);
+
+        $entity = $this->createMock(AbstractEntity::class);
+
+        $entity->expects($this->once())
+            ->method('setCreatedAt')
+            ->with($this->isInstanceOf(DateTime::class));
+
+        $entity->expects($this->once())
+            ->method('setUpdatedAt')
+            ->with($this->isInstanceOf(DateTime::class));
+
+        $entity->method('getCreatedAt')->willReturn(null);
+
+        $entityManager = $this->createMock(EntityManagerInterface::class);
+        $args          = new LifecycleEventArgs($entity, $entityManager);
+
+        $this->subscriber->prePersist($args);
+    }
+
+    public function testPreUpdateSetsUpdatedAt(): void
+    {
+        $now = new DateTimeImmutable('2024-10-10 12:00:00');
+        $this->clock->method('now')->willReturn($now);
+
+        $entity = $this->createMock(AbstractEntity::class);
+
+        $entity->expects($this->never())
+            ->method('setCreatedAt');
+
+        $entity->expects($this->once())
+            ->method('setUpdatedAt')
+            ->with($this->isInstanceOf(DateTime::class));
+
+        $entity->method('getCreatedAt')->willReturn(new DateTime());
+
+        $entityManager = $this->createMock(EntityManagerInterface::class);
+        $args          = new LifecycleEventArgs($entity, $entityManager);
+
+        $this->subscriber->preUpdate($args);
+    }
+
+    public function testEntityNotInstanceOfAbstractEntity(): void
+    {
+        $nonEntity = new stdClass();
+
+        $entityManager = $this->createMock(EntityManagerInterface::class);
+        $args          = new LifecycleEventArgs($nonEntity, $entityManager);
+
+        $this->subscriber->prePersist($args);
+        $this->subscriber->preUpdate($args);
+
+        $this->assertTrue(true);
+    }
+}