Do not return not exists error in history pagination function (cadenc…

…e-workflow#5054)

Co-authored-by: David Porter <[email protected]>

common/persistence/historyManager.go

@@ -422,6 +422,7 @@ func (m *historyV2ManagerImpl) readRawHistoryBranch(
 	if err != nil {
 		return nil, nil, 0, nil, err
 	}
+	// TODO: consider if it's possible to remove this branch
 	if len(resp.History) == 0 && len(request.NextPageToken) == 0 {
 		return nil, nil, 0, nil, &types.EntityNotExistsError{Message: "Workflow execution history not found."}
 	}

common/persistence/persistence-utils/historyManagerUtil.go

@@ -22,6 +22,7 @@ package persistenceutils
 
 import (
 	"context"
+	"errors"
 
 	"github.com/uber/cadence/common/cache"
 	"github.com/uber/cadence/common/persistence"
@@ -125,6 +126,10 @@ func PaginateHistory(
 	if byBatch {
 		response, err := historyV2Mgr.ReadHistoryBranchByBatch(ctx, req)
 		if err != nil {
+			var e *types.EntityNotExistsError
+			if errors.As(err, &e) {
+				return nil, nil, nil, 0, nil
+			}
 			return nil, nil, nil, 0, err
 		}
 
@@ -136,6 +141,10 @@ func PaginateHistory(
 	} else {
 		response, err := historyV2Mgr.ReadHistoryBranch(ctx, req)
 		if err != nil {
+			var e *types.EntityNotExistsError
+			if errors.As(err, &e) {
+				return nil, nil, nil, 0, nil
+			}
 			return nil, nil, nil, 0, err
 		}