[Hot fix] Fix build threads (dmlc#1133)

* tf * add builtin support * fiix * pytest * fix * fix * fix some bugs * fix selecting * fix todo * fix test * fix test fail in tf * fix * fix * fix gather row * fix gather row * log backend * fix gather row * fix gather row * fix for pytorch * fix * fix * fix * fix * fix * fix tests * fix * fix * fix * fix * fix * fix * fix convert * fix * fix * fix * fix inplace * add alignment setting * add debug option * Revert "add alignment setting" This reverts commit ec63fb3. * tf ci * fix lint * fix lint * add tfdlpack * fix type * add env * fix backend * fix * fix tests * remove one_hot * remove comment * remove comment * fix * use pip to install all * fix test * fix base * fix * fix * add skip * upgrade cmake * change version * change ci * fix * fix * fix * fix * fix seg fault * fix * fix python version * fix * try fix * fix * fix * tf takes longer time in ci * change py version * fix * fix * fix oom * change kg env * change kg env * 啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊啊 * 我再也不搞各种乱七八糟环境了…… * use pytest * Chang image * try node * try * fix * try new ci * try new ci * try new ci * try new ci * ci * try * try * fix * hot fix * fix * fix cpp test * add comments
shashankg7 · Dec 23, 2019 · a1b28b3 · a1b28b3
1 parent 2ab4d0e
commit a1b28b3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/src/runtime/workspace_pool.cc b/src/runtime/workspace_pool.cc
@@ -117,6 +117,11 @@ WorkspacePool::WorkspacePool(DLDeviceType device_type, std::shared_ptr<DeviceAPI
 }
 
 WorkspacePool::~WorkspacePool() {
+  /*
+   Comment out the destruct of WorkspacePool, due to Segmentation fault with MXNet
+   Since this will be only called at the termination of process,
+   not manually wiping out should not cause problems.
+  */
   // for (size_t i = 0; i < array_.size(); ++i) {
   //   if (array_[i] != nullptr) {
   //     DGLContext ctx;

diff --git a/tests/compute/test_kernel.py b/tests/compute/test_kernel.py
@@ -303,6 +303,8 @@ def rfunc(nodes):
         def _print_error(a, b):
             print("ERROR: Test {}_{}_{}_{} broadcast: {} partial: {}".
                   format(lhs, binary_op, rhs, reducer, broadcast, partial))
+            print("Nodes", g.nodes())
+            print("Edges:" ,g.edges())
             for i, (x, y) in enumerate(zip(F.asnumpy(a).flatten(), F.asnumpy(b).flatten())):
                 if not np.allclose(x, y, rtol, atol):
                     print('@{} {} v.s. {}'.format(i, x, y))

diff --git a/tests/scripts/build_dgl.sh b/tests/scripts/build_dgl.sh
@@ -22,7 +22,7 @@ rm -rf _download
 
 pushd build
 cmake $CMAKE_VARS ..
-make -j8
+make -j4
 popd
 
 pushd python

diff --git a/tests/scripts/task_cpp_unit_test.sh b/tests/scripts/task_cpp_unit_test.sh
@@ -1,6 +1,7 @@
 #!/bin/bash
 echo $PWD
-ls -lh
 pushd build
-./runUnitTests
+ls -lh
+export LD_LIBRARY_PATH=$PWD:$LD_LIBRARY_PATH
+./runUnitTests || fail "CPP unit test"
 popd