Review Changes

sheetalghori · Aug 23, 2018 · 4cf9b0e · 4cf9b0e
1 parent ab93a7c
commit 4cf9b0e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -64,6 +64,12 @@ pub global run flutter_plugin_tools format --plugins package_name
 pub global run flutter_plugin_tools analyze --plugins package_name
 pub global run flutter_plugin_tools test --plugins package_name
 ```
+ * Check that the package can be published (but don't publish it until it has landed!):
+
+```
+cd packages/package_name; pub publish --dry-run
+```
+
  * `git commit -a -m "<your informative commit message>"`
  * `git push origin <name_of_your_branch>`
 

diff --git a/README.md b/README.md
@@ -1,7 +1,6 @@
 # Flutter Packages
 
-[![Build Status](https://travis-ci.org/flutter/packages.svg?branch=master)](https://travis-ci.org/flutter/packages)
-[![Build Status](https://api.cirrus-ci.com/github/flutter/packages.svg)](https://cirrus-ci.com/github/flutter/packages)
+[![Build Status](https://api.cirrus-ci.com/github/flutter/packages.svg)](https://cirrus-ci.com/github/flutter/packages/master)
 
 This repo is a companion repo to the main [flutter repo](
 https://github.com/flutter/flutter). It contains the source code for Flutter's

diff --git a/packages/palette_generator/test/palette_generator_test.dart b/packages/palette_generator/test/palette_generator_test.dart
@@ -65,12 +65,11 @@ void main() async {
     testImages[name] = await loadImage('$name.png');
   }
 
-  testWidgets('Initialize the image cache', (WidgetTester tester) {
+  testWidgets('Initialize the image cache', (WidgetTester tester) async {
     // We need to have a testWidgets test in order to initialize the image
     // cache for the other tests, but they timeout if they too are testWidgets
     // tests.
     tester.pumpWidget(const Placeholder());
-    return new Future<Null>.value();
   });
 
   test('PaletteGenerator works on 1-pixel wide blue image', () async {