🐛 bugfix: duration is displayed as 00:00

shengl8 · Sep 6, 2018 · d0bdfad · d0bdfad
1 parent 624e714
commit d0bdfad
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/app/src/main/java/by/naxa/soundrecorder/util/TimeUtils.java b/app/src/main/java/by/naxa/soundrecorder/util/TimeUtils.java
@@ -6,25 +6,23 @@
 public class TimeUtils {
 
     public static String formatDuration(long millis) {
-        String format;
+        final String sign;
         if (millis < 0) {
-            format = "-";
+            sign = "-";
             millis = -millis;
         } else {
-            format = "";
+            sign = "";
         }
 
         long hours = TimeUnit.MILLISECONDS.toHours(millis);
         long minutes = TimeUnit.MILLISECONDS.toMinutes(millis) - TimeUnit.HOURS.toMinutes(hours);
         long seconds = TimeUnit.MILLISECONDS.toSeconds(millis) - TimeUnit.HOURS.toSeconds(hours)
                 - TimeUnit.MINUTES.toSeconds(minutes);
         if (hours > 0) {
-            format += "%d:%02d:%02d";
+            return String.format(Locale.ENGLISH, sign + "%d:%02d:%02d", hours, minutes, seconds);
         } else {
-            format += "%02d:%02d";
+            return String.format(Locale.ENGLISH, sign + "%02d:%02d", minutes, seconds);
         }
-
-        return String.format(Locale.ENGLISH, format, hours, minutes, seconds);
     }
 
 }