[feat] add icon and analysis enabled logic

README.md

@@ -1,3 +1,5 @@
+<img src="doc/icon.png" alt="logo" width="20%" />
+
 # Knight
 
 Knight is a static analysis tool for c/c++ programs written in C++20.

include/dfa/analysis_manager.hpp

@@ -141,7 +141,6 @@ class AnalysisManager {
                            internal::VisitStmtKind kind);
     /// @}
 
-  private:
     /// \brief check analysis is enabled or not
     void add_required_analysis(AnalysisID id);
 

include/tooling/factory.hpp

@@ -46,15 +46,17 @@ class CheckerManager;
 class KnightFactory {
   public:
     using Analysis = dfa::AnalysisBase;
+    using UniqueAnalysisRef = std::unique_ptr< Analysis >;
     using AnalysisRef = std::unique_ptr< Analysis >;
     using AnalysisRefs = std::vector< AnalysisRef >;
 
     using Checker = dfa::CheckerBase;
-    using CheckerRef = std::unique_ptr< Checker >;
+    using UniqueCheckerRef = std::unique_ptr< Checker >;
+    using CheckerRef = Checker*;
     using CheckerRefs = std::vector< CheckerRef >;
 
-    using AnalysisRegistryFn = std::function< AnalysisRef() >;
-    using CheckerRegistryFn = std::function< CheckerRef() >;
+    using AnalysisRegistryFn = std::function< UniqueAnalysisRef() >;
+    using CheckerRegistryFn = std::function< UniqueCheckerRef() >;
 
     using AnalysisRegistryFnMap =
         llvm::DenseMap< std::pair< dfa::AnalysisID, llvm::StringRef >,

src/dfa/checker_manager.cpp

@@ -24,13 +24,14 @@ void CheckerManager::register_checker(CheckerID id) {
 }
 
 bool CheckerManager::is_checker_required(CheckerID id) const {
-    return m_enabled_checkers.count(id) > 0U;
+    return m_required_checkers.count(id) > 0U;
 }
 
 void CheckerManager::enable_checker(
     // TODO: add enabling logic for checkers (check filter and required checkers)
     std::unique_ptr< CheckerBase > checker) {
     auto id = checker->get_id();
+    m_required_checkers.emplace(id);
     m_enabled_checkers.emplace(id, std::move(checker));
 }
 

src/tooling/factory.cpp

@@ -56,8 +56,9 @@ KnightFactory::CheckerRefs KnightFactory::create_checkers(
     const auto& LO = context->get_lang_options();
     for (const auto& [checker, registry] : m_checker_registry) {
         if (m_checker_mgr.is_checker_required(checker.first)) {
-            CheckerRef checker = registry();
-            checkers.push_back(std::move(checker));
+            auto checker = registry();
+            checkers.push_back(checker.get());
+            m_checker_mgr.enable_checker(std::move(checker));
         }
     }
     return checkers;

src/tooling/knight.cpp

@@ -58,10 +58,17 @@ std::unique_ptr< clang::ASTConsumer > KnightASTConsumerFactory::
         m_ctx.set_current_build_dir(working_dir.get());
     }
 
-    // TODO: add checkers and analyses register and enabled logic here.
-
+    for (const auto& [id, _] : get_enabled_checks()) {
+        m_checker_manager->register_checker(id);
+    }
     auto checkers = m_factory->create_checkers(&m_ctx);
+
+    for (const auto& [id, _] : get_directly_enabled_analyses()) {
+        m_analysis_manager->register_analysis(id);
+    }
+    m_analysis_manager->compute_all_required_analyses_by_dependencies();
     auto analyses = m_factory->create_analyses(&m_ctx);
+
     return std::make_unique< KnightASTConsumer >(m_ctx,
                                                  *m_analysis_manager,
                                                  *m_checker_manager,