Make ReplayingDecoder.newCumulationBuffer() overridable / Make Replay…

…ing|FrameDecoder allocate at least 256 bytes by default

codec/src/main/java/io/netty/handler/codec/frame/FrameDecoder.java

@@ -361,6 +361,6 @@ protected ChannelBuffer newCumulationBuffer(
             ChannelHandlerContext ctx, int minimumCapacity) {
         ChannelBufferFactory factory = ctx.getChannel().getConfig().getBufferFactory();
         return ChannelBuffers.dynamicBuffer(
-                factory.getDefaultOrder(), minimumCapacity, factory);
+                factory.getDefaultOrder(), Math.max(minimumCapacity, 256), factory);
     }
 }

codec/src/main/java/io/netty/handler/codec/replay/ReplayingDecoder.java

@@ -18,6 +18,7 @@
 import java.net.SocketAddress;
 
 import io.netty.buffer.ChannelBuffer;
+import io.netty.buffer.ChannelBufferFactory;
 import io.netty.buffer.ChannelBuffers;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelHandler;
@@ -596,9 +597,19 @@ private void cleanup(ChannelHandlerContext ctx, ChannelStateEvent e)
         }
     }
 
-    private ChannelBuffer newCumulationBuffer(
+    /**
+     * Create a new {@link ChannelBuffer} which is used for the cumulation.
+     * Be aware that this MUST be a dynamic buffer. Sub-classes may override
+     * this to provide a dynamic {@link ChannelBuffer} which has some
+     * pre-allocated size that better fit their need.
+     *
+     * @param ctx {@link ChannelHandlerContext} for this handler
+     * @return buffer the {@link ChannelBuffer} which is used for cumulation
+     */
+    protected ChannelBuffer newCumulationBuffer(
             ChannelHandlerContext ctx, int minimumCapacity) {
-        return new UnsafeDynamicChannelBuffer(
-                ctx.getChannel().getConfig().getBufferFactory(), minimumCapacity);
+        ChannelBufferFactory factory = ctx.getChannel().getConfig().getBufferFactory();
+        return ChannelBuffers.dynamicBuffer(
+                factory.getDefaultOrder(), Math.max(minimumCapacity, 256), factory);
     }
 }