Skip to content

Commit

Permalink
docs(migration): add end to end upgrade info to migration doc
Browse files Browse the repository at this point in the history
There are a couple of changes to some Protractor tests that need to be made
when migrating from AngularJS 1.2 to 1.3 - document these in the migration
guide.

See angular/protractor#1480

Closes angular#10377
  • Loading branch information
juliemr authored and petebacondarwin committed Dec 15, 2014
1 parent 9b96cea commit 0524e92
Showing 1 changed file with 39 additions and 0 deletions.
39 changes: 39 additions & 0 deletions docs/content/guide/migration.ngdoc
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,45 @@ After:
Please view the documentation for ngAnimate for more info.


## Testing

- due to [85880a64](https://github.com/angular/angular.js/commit/85880a64900fa22a61feb926bf52de0965332ca5), some deprecated features of
Protractor tests no longer work.

`by.binding(descriptor)` no longer allows using the surrounding interpolation
markers in the descriptor (the default interpolation markers are `{{}}`).
Previously, these were optional.

Before:

var el = element(by.binding('{{foo}}'));

After:

var el = element(by.binding('foo'));

Prefixes `ng_` and `x-ng-` are no longer allowed for models. Use `ng-model`.

`by.repeater` cannot find elements by row and column which are not children of
the row. For example, if your template is

<div ng-repeat="foo in foos">{{foo.name}}</div>

Before:

var el = element(by.repeater('foo in foos').row(2).column('foo.name'))

After:

You may either enclose `{{foo.name}}` in a child element

<div ng-repeat="foo in foos"><span>{{foo.name}}</span></div>

or simply use:

var el = element(by.repeater('foo in foos').row(2))


## Internet Explorer 8

- due to [eaa1d00b](https://github.com/angular/angular.js/commit/eaa1d00b24008f590b95ad099241b4003688cdda),
Expand Down

0 comments on commit 0524e92

Please sign in to comment.