Skip to content

Commit

Permalink
chore(changelog): add test for addition of trailing newline
Browse files Browse the repository at this point in the history
Adds tests for the functionality added by angular#9550.

Closes angular#10358
  • Loading branch information
gkalpak authored and caitp committed Dec 8, 2014
1 parent 924d3c6 commit c5cba6e
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ var generate = function(version, file) {

// publish for testing
exports.parseRawCommit = parseRawCommit;
exports.printSection = printSection;

// hacky start if not run by jasmine :-D
if (process.argv.join('').indexOf('jasmine-node') === -1) {
Expand Down
63 changes: 62 additions & 1 deletion changelog.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global describe: false, it: false, expect: false */
/* global describe: false, beforeEach: false, afterEach: false, it: false, expect: false */

'use strict';

Expand Down Expand Up @@ -44,4 +44,65 @@ describe('changelog.js', function() {
expect(msg.breaking).toEqual(' first breaking change\nsomething else\nanother line with more info\n');
});
});

describe('printSection', function() {
var output;
var streamMock = {
write: function(str) {
output += str;
}
};

beforeEach(function() {
output = '';
});

it('should add a new line at the end of each breaking change list item ' +
'when there is 1 item per component', function() {
var title = 'test';
var printCommitLinks = false;

var section = {
module1: [{subject: 'breaking change 1'}],
module2: [{subject: 'breaking change 2'}]
};
var expectedOutput =
'\n' + '## test\n\n' +
'- **module1:** breaking change 1\n' +
'- **module2:** breaking change 2\n' +
'\n';

ch.printSection(streamMock, title, section, printCommitLinks);
expect(output).toBe(expectedOutput);
});

it('should add a new line at the end of each breaking change list item ' +
'when there are multiple items per component', function() {
var title = 'test';
var printCommitLinks = false;

var section = {
module1: [
{subject: 'breaking change 1.1'},
{subject: 'breaking change 1.2'}
],
module2: [
{subject: 'breaking change 2.1'},
{subject: 'breaking change 2.2'}
]
};
var expectedOutput =
'\n' + '## test\n\n' +
'- **module1:**\n' +
' - breaking change 1.1\n' +
' - breaking change 1.2\n' +
'- **module2:**\n' +
' - breaking change 2.1\n' +
' - breaking change 2.2\n' +
'\n';

ch.printSection(streamMock, title, section, printCommitLinks);
expect(output).toBe(expectedOutput);
});
});
});

0 comments on commit c5cba6e

Please sign in to comment.