fix: Change "Save" button naming (snapshot-labs#4085)

* Change button naming * Remove redundant optional chaining
shin4141 · Jul 22, 2023 · 335f6f2 · 335f6f2
1 parent f6652fb
commit 335f6f2
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/src/components/ModalPlugins.vue b/src/components/ModalPlugins.vue
@@ -103,7 +103,7 @@ watch(open, () => {
         primary
         @click="handleSubmit"
       >
-        {{ Object.keys(plugin).length ? $t('save') : $t('add') }}
+        {{ Object.keys(plugin).length ? $t('applyChanges') : $t('add') }}
       </BaseButton>
     </template>
   </BaseModal>

diff --git a/src/components/ModalTreasury.vue b/src/components/ModalTreasury.vue
@@ -41,7 +41,7 @@ function handleSubmit() {
 }
 
 watch(open, () => {
-  if (props.treasury?.name) {
+  if (props.treasury.name) {
     input.value = props.treasury;
   } else {
     input.value = {
@@ -95,7 +95,7 @@ watch(open, () => {
         primary
         @click="handleSubmit"
       >
-        {{ $t('save') }}
+        {{ treasury.name ? $t('applyChanges') : $t('add') }}
       </BaseButton>
     </template>
   </BaseModal>

diff --git a/src/components/ModalValidation.vue b/src/components/ModalValidation.vue
@@ -203,7 +203,7 @@ watch(showStrategies, () => {
     </div>
     <template v-if="input.name" #footer>
       <BaseButton class="w-full" primary @click="handleSubmit">
-        {{ $t('save') }}
+        {{ $t('applyChanges') }}
       </BaseButton>
     </template>
   </BaseModal>

diff --git a/src/components/ModalVoteValidation.vue b/src/components/ModalVoteValidation.vue
@@ -202,7 +202,7 @@ watch(showStrategies, () => {
     </div>
     <template v-if="input.name" #footer>
       <BaseButton class="w-full" primary @click="handleSubmit">
-        {{ $t('save') }}
+        {{ $t('applyChanges') }}
       </BaseButton>
     </template>
   </BaseModal>

diff --git a/src/locales/default.json b/src/locales/default.json
@@ -11,6 +11,7 @@
   "poweredBy": "Powered by",
   "results": "Results",
   "failed": "Failed",
+  "applyChanges": "Apply changes",
   "resultsError": "Results could not be calculated. This is often due to a misconfigured strategy or an unresponsive RPC node involved in the strategy.",
   "ticketWithAnyOrBasicError": "In order to use the \"ticket\" strategy you are required to set a voting validation strategy. This combination reduces the risk of spam and sybil attacks. {article}",
   "ticketWithAnyOrBasicErrorSetup": "Use of the ticket strategy requires setting a voting validation strategy. To continue go one step back and select the \"One person, one vote\" option. {article}",