Skip to content

Commit

Permalink
core: init: ASLR offset leak in initcall error message
Browse files Browse the repository at this point in the history
Initial call error message print out call pointer. This leak
the ASLR offset. Subtract VA start address to hide ASLR offset.

Signed-off-by: Khoa Hoang <[email protected]>
Reviewed-by: Jens Wiklander <[email protected]>
[jf: s/Initial call/Initcall/, wrap line, uppercase ASLR in subject]
Signed-off-by: Jerome Forissier <[email protected]>
Reviewed-by: Jerome Forissier <[email protected]>
  • Loading branch information
maximus64 authored and jforissier committed Mar 4, 2020
1 parent 2b6dd0d commit 7e8696a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/arch/arm/tee/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ static void call_initcalls(void)
TEE_Result ret;
ret = (*call)();
if (ret != TEE_SUCCESS) {
EMSG("Initial call 0x%08" PRIxVA " failed",
(vaddr_t)call);
EMSG("Initcall __text_start + 0x%08" PRIxVA
" failed", (vaddr_t)call - VCORE_START_VA);
}
}
}
Expand Down

0 comments on commit 7e8696a

Please sign in to comment.