Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): ensure all control bar icons are hidden when isLive is enabled #149

Merged
merged 8 commits into from
Jan 8, 2025

Conversation

code-lish
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oplayer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 10:37am

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for ohplayer ready!

Name Link
🔨 Latest commit bb6ff17
🔍 Latest deploy log https://app.netlify.com/sites/ohplayer/deploys/677e55031a319e000852a49c
😎 Deploy Preview https://deploy-preview-149--ohplayer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@code-lish
Copy link
Contributor Author

@shiyiya
When you will merge this branch?

@shiyiya
Copy link
Owner

shiyiya commented Jan 8, 2025

@shiyiya When you will merge this branch?

Could you please test again?

@code-lish
Copy link
Contributor Author

code-lish commented Jan 8, 2025

@shiyiya
You did not merge the PR what I should test?

@code-lish
Copy link
Contributor Author

@shiyiya
even I tried the "progress?.mini" it did not work fine it does not hide the icons completely,
because of that ,I change the padding and the translate(y)

@shiyiya
Copy link
Owner

shiyiya commented Jan 8, 2025

run git pull, then test it

@code-lish
Copy link
Contributor Author

@shiyiya
Ok will do it

thank you

@shiyiya shiyiya merged commit 62cbd7f into shiyiya:main Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants