Ship large meassure cache in all platforms

Summary: Ship large meassure cache in all platforms changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D40356835 fbshipit-source-id: 315862d7aa705e83086e102e20fe2c20fb3210b2
shreeve · Oct 18, 2022 · 9578c2c · 9578c2c
1 parent 4f7b4d8
commit 9578c2c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 15 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
@@ -84,12 +84,6 @@ public class ReactFeatureFlags {
 
   public static boolean insertZReorderBarriersOnViewGroupChildren = true;
 
-  /**
-   * Feature Flag to control the size of the cache used by TextLayoutManager in Fabric. Used from
-   * JNI.
-   */
-  public static boolean enableLargeTextMeasureCache = true;
-
   public static boolean dispatchPointerEvents = false;
 
   /** Feature Flag to enable the pending event queue in fabric before mounting views */

diff --git a/ReactAndroid/src/main/jni/react/fabric/Binding.cpp b/ReactAndroid/src/main/jni/react/fabric/Binding.cpp
@@ -443,10 +443,6 @@ void Binding::installFabricUIManager(
   dispatchPreallocationInBackground_ = reactNativeConfig_->getBool(
       "react_native_new_architecture:dispatch_preallocation_in_bg");
 
-  contextContainer->insert(
-      "EnableLargeTextMeasureCache",
-      getFeatureFlagValue("enableLargeTextMeasureCache"));
-
   // Props setter pattern feature
   CoreFeatures::enablePropIteratorSetter =
       getFeatureFlagValue("enableCppPropsIteratorSetter");

diff --git a/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.h b/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.h
@@ -71,7 +71,7 @@ class TextMeasureCacheKey final {
  * The number was empirically chosen based on approximation of an average amount
  * of meaningful measures per surface.
  */
-constexpr auto kSimpleThreadSafeCacheSizeCap = size_t{256};
+constexpr auto kSimpleThreadSafeCacheSizeCap = size_t{1024};
 
 /*
  * Thread-safe, evicting hash table designed to store text measurement

diff --git a/...textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp b/...textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp
@@ -146,10 +146,7 @@ Size measureAndroidComponentMapBuffer(
 TextLayoutManager::TextLayoutManager(
     const ContextContainer::Shared &contextContainer)
     : contextContainer_(contextContainer),
-      measureCache_(
-          contextContainer->at<bool>("EnableLargeTextMeasureCache")
-              ? 1024
-              : kSimpleThreadSafeCacheSizeCap) {}
+      measureCache_(kSimpleThreadSafeCacheSizeCap) {}
 
 void *TextLayoutManager::getNativeTextLayoutManager() const {
   return self_;