forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: While it would be better to be able to do all of the ownership metadata at the Buck macro level, that proved to be more work than expected. This diff adds the corresponding pfh label to all targets in `xplat/js/react-native-github` that have a Supermodule label. Once the migration is complete the Supermodules labels will be able to be removed. Reviewed By: cortinico Differential Revision: D35221544 fbshipit-source-id: d87d5e266dfb5e6ee087251dc34dff5db299bbaf
- Loading branch information
1 parent
0353852
commit ceae48c
Showing
142 changed files
with
666 additions
and
161 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,6 +98,7 @@ rn_xplat_cxx_library2( | |
# it's linked in your app, transparently use it". | ||
labels = [ | ||
"depslint_never_remove", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode() + [ | ||
|
@@ -154,7 +155,10 @@ rn_xplat_cxx_library2( | |
frameworks = [ | ||
"$SDKROOT/System/Library/Frameworks/Foundation.framework", | ||
], | ||
labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode() + ["-DWITH_FBSYSTRACE=1"], | ||
visibility = ["PUBLIC"], | ||
deps = [ | ||
|
@@ -191,7 +195,10 @@ rn_xplat_cxx_library2( | |
frameworks = [ | ||
"$SDKROOT/System/Library/Frameworks/Foundation.framework", | ||
], | ||
labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
visibility = ["PUBLIC"], | ||
deps = [ | ||
|
@@ -216,7 +223,10 @@ rn_xplat_cxx_library2( | |
), | ||
contacts = ["[email protected]"], | ||
fbobjc_enable_exceptions = True, | ||
labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
visibility = ["PUBLIC"], | ||
deps = [ | ||
|
@@ -419,6 +429,7 @@ rn_xplat_cxx_library2( | |
labels = [ | ||
"depslint_never_add", | ||
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
platform_preprocessor_flags = [( | ||
|
@@ -509,6 +520,7 @@ rn_xplat_cxx_library2( | |
header_path_prefix = "React", | ||
labels = [ | ||
"disable_plugins_only_validation", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = [ | ||
|
@@ -591,7 +603,10 @@ rn_apple_library( | |
"$PLATFORM_DIR/Developer/Library/Frameworks/Foundation.framework", | ||
], | ||
inherited_buck_flags = get_static_library_ios_flags(), | ||
labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
reexport_all_header_dependencies = True, | ||
deps = [ | ||
|
@@ -661,6 +676,7 @@ rn_apple_library( | |
contacts = ["[email protected]"], | ||
labels = [ | ||
"disable_plugins_only_validation", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = [react_fabric_component_plugin_provider("Image", "RCTImageCls")], | ||
|
@@ -691,7 +707,10 @@ rn_xplat_cxx_library2( | |
}, | ||
compiler_flags = ["-Wall"], | ||
contacts = ["[email protected]"], | ||
labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
visibility = ["PUBLIC"], | ||
deps = [ | ||
"//xplat/js/react-native-github:RCTImage", | ||
|
@@ -720,7 +739,10 @@ rn_library( | |
"Libraries/Components/Switch/SwitchSchema.js", | ||
], | ||
), | ||
labels = ["supermodule:xplat/default/public.react_native.core"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.core", | ||
], | ||
visibility = ["PUBLIC"], | ||
deps = [ | ||
"//xplat/js:node_modules__abort_19controller", | ||
|
@@ -757,7 +779,10 @@ rn_codegen( | |
android_package_name = "com.facebook.fbreact.specs", | ||
codegen_modules = True, | ||
ios_assume_nonnull = False, | ||
library_labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
library_labels = [ | ||
"supermodule:xplat/default/public.react_native.infra", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
], | ||
native_module_spec_name = "FBReactNativeSpec", | ||
src_prefix = "Libraries/", | ||
) | ||
|
@@ -767,7 +792,10 @@ rn_codegen( | |
name = "FBReactNativeComponentSpec", | ||
codegen_components = True, | ||
ios_assume_nonnull = False, | ||
library_labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
library_labels = [ | ||
"supermodule:xplat/default/public.react_native.infra", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
], | ||
src_prefix = "Libraries/", | ||
) | ||
|
||
|
@@ -801,6 +829,7 @@ rn_apple_library( | |
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"disable_plugins_only_validation", | ||
"extension_api_allow_unsafe_unavailable_usages", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = | ||
|
@@ -850,6 +879,7 @@ rn_apple_library( | |
labels = [ | ||
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"disable_plugins_only_validation", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = | ||
|
@@ -908,6 +938,7 @@ rn_apple_library( | |
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"disable_plugins_only_validation", | ||
"extension_api_allow_unsafe_unavailable_usages", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = | ||
|
@@ -955,6 +986,7 @@ rn_apple_library( | |
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"disable_plugins_only_validation", | ||
"extension_api_allow_unsafe_unavailable_usages", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = | ||
|
@@ -1006,6 +1038,7 @@ rn_apple_library( | |
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"disable_plugins_only_validation", | ||
"extension_api_allow_unsafe_unavailable_usages", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = | ||
|
@@ -1086,6 +1119,7 @@ rn_apple_library( | |
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"disable_plugins_only_validation", | ||
"extension_api_allow_unsafe_unavailable_usages", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = | ||
|
@@ -1219,6 +1253,7 @@ rn_xplat_cxx_library2( | |
], | ||
labels = [ | ||
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
|
@@ -1251,6 +1286,7 @@ rn_apple_library( | |
labels = [ | ||
"depslint_never_remove", | ||
"disable_plugins_only_validation", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
plugins = react_module_plugin_providers( | ||
|
@@ -1291,6 +1327,7 @@ rn_xplat_cxx_library2( | |
], | ||
labels = [ | ||
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
|
@@ -1323,6 +1360,7 @@ rn_xplat_cxx_library2( | |
], | ||
labels = [ | ||
"depslint_never_remove", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
|
@@ -1357,6 +1395,7 @@ rn_xplat_cxx_library2( | |
], | ||
labels = [ | ||
"depslint_never_remove", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
|
@@ -1392,6 +1431,7 @@ rn_xplat_cxx_library2( | |
], | ||
labels = [ | ||
"depslint_never_remove", | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(), | ||
|
@@ -1413,6 +1453,7 @@ rn_xplat_cxx_library2( | |
"React/RCTConvert+CoreLocation.h": RCTVIEWS_PATH + "RCTConvert+CoreLocation.h", | ||
}, | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
visibility = [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,5 +10,8 @@ fb_apple_library( | |
contacts = ["[email protected]"], | ||
extension_api_only = True, | ||
frameworks = ["Foundation"], | ||
labels = ["supermodule:xplat/default/public.react_native.infra"], | ||
labels = [ | ||
"pfh:ReactNative_CommonInfrastructurePlaceholde", | ||
"supermodule:xplat/default/public.react_native.infra", | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.