Add Effect::Dim (gyscos#580)

The "dim" or "faint" effect is set by the ANSI escape code `ESC[2m`, and supported in some terminals. It's more or less the opposite of the "bold" effect. I couldn't get `ncurses`/`pancurses` to render anything differently, even though there's apparently an `A_DIM` constant; I'm not sure why. It renders with `crossterm` and `termion`.
shritesh · May 19, 2021 · d64131f · d64131f
1 parent 7ea3a73
commit d64131f
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 4 deletions.
diff --git a/cursive-core/src/theme/effect.rs b/cursive-core/src/theme/effect.rs
@@ -8,6 +8,8 @@ pub enum Effect {
     Simple,
     /// Reverses foreground and background colors
     Reverse,
+    /// Prints foreground as "dim" or "faint" (has no effect for ncurses/pancurses/blt backends)
+    Dim,
     /// Prints foreground in bold
     Bold,
     /// Prints foreground in italic

diff --git a/cursive/src/backends/blt.rs b/cursive/src/backends/blt.rs
@@ -267,7 +267,8 @@ impl backend::Backend for Backend {
     fn set_effect(&self, effect: Effect) {
         match effect {
             // TODO: does BLT support bold/italic/strikethrough/underline?
-            Effect::Bold
+            Effect::Dim
+            | Effect::Bold
             | Effect::Italic
             | Effect::Underline
             | Effect::Strikethrough
@@ -286,7 +287,8 @@ impl backend::Backend for Backend {
     fn unset_effect(&self, effect: Effect) {
         match effect {
             // TODO: does BLT support bold/italic/strikethrough/underline?
-            Effect::Bold
+            Effect::Dim
+            | Effect::Bold
             | Effect::Italic
             | Effect::Underline
             | Effect::Strikethrough

diff --git a/cursive/src/backends/crossterm.rs b/cursive/src/backends/crossterm.rs
@@ -362,6 +362,7 @@ impl backend::Backend for Backend {
         match effect {
             theme::Effect::Simple => (),
             theme::Effect::Reverse => self.set_attr(Attribute::Reverse),
+            theme::Effect::Dim => self.set_attr(Attribute::Dim),
             theme::Effect::Bold => self.set_attr(Attribute::Bold),
             theme::Effect::Blink => self.set_attr(Attribute::SlowBlink),
             theme::Effect::Italic => self.set_attr(Attribute::Italic),
@@ -376,7 +377,7 @@ impl backend::Backend for Backend {
         match effect {
             theme::Effect::Simple => (),
             theme::Effect::Reverse => self.set_attr(Attribute::NoReverse),
-            theme::Effect::Bold => self.set_attr(Attribute::NormalIntensity),
+            theme::Effect::Dim | theme::Effect::Bold => self.set_attr(Attribute::NormalIntensity),
             theme::Effect::Blink => self.set_attr(Attribute::NoBlink),
             theme::Effect::Italic => self.set_attr(Attribute::NoItalic),
             theme::Effect::Strikethrough => {

diff --git a/cursive/src/backends/curses/n.rs b/cursive/src/backends/curses/n.rs
@@ -367,6 +367,7 @@ impl backend::Backend for Backend {
         let style = match effect {
             Effect::Reverse => ncurses::A_REVERSE(),
             Effect::Simple => ncurses::A_NORMAL(),
+            Effect::Dim => ncurses::A_DIM(),
             Effect::Bold => ncurses::A_BOLD(),
             Effect::Blink => ncurses::A_BLINK(),
             Effect::Italic => ncurses::A_ITALIC(),
@@ -380,6 +381,7 @@ impl backend::Backend for Backend {
         let style = match effect {
             Effect::Reverse => ncurses::A_REVERSE(),
             Effect::Simple => ncurses::A_NORMAL(),
+            Effect::Dim => ncurses::A_DIM(),
             Effect::Bold => ncurses::A_BOLD(),
             Effect::Blink => ncurses::A_BLINK(),
             Effect::Italic => ncurses::A_ITALIC(),

diff --git a/cursive/src/backends/curses/pan.rs b/cursive/src/backends/curses/pan.rs
@@ -411,6 +411,7 @@ impl backend::Backend for Backend {
         let style = match effect {
             Effect::Simple => pancurses::Attribute::Normal,
             Effect::Reverse => pancurses::Attribute::Reverse,
+            Effect::Dim => pancurses::Attribute::Dim,
             Effect::Bold => pancurses::Attribute::Bold,
             Effect::Blink => pancurses::Attribute::Blink,
             Effect::Italic => pancurses::Attribute::Italic,
@@ -424,6 +425,7 @@ impl backend::Backend for Backend {
         let style = match effect {
             Effect::Simple => pancurses::Attribute::Normal,
             Effect::Reverse => pancurses::Attribute::Reverse,
+            Effect::Dim => pancurses::Attribute::Dim,
             Effect::Bold => pancurses::Attribute::Bold,
             Effect::Blink => pancurses::Attribute::Blink,
             Effect::Italic => pancurses::Attribute::Italic,

diff --git a/cursive/src/backends/termion.rs b/cursive/src/backends/termion.rs
@@ -247,6 +247,7 @@ impl backend::Backend for Backend {
         match effect {
             theme::Effect::Simple => (),
             theme::Effect::Reverse => self.write(tstyle::Invert),
+            theme::Effect::Dim => self.write(tstyle::Faint),
             theme::Effect::Bold => self.write(tstyle::Bold),
             theme::Effect::Blink => self.write(tstyle::Blink),
             theme::Effect::Italic => self.write(tstyle::Italic),
@@ -259,7 +260,9 @@ impl backend::Backend for Backend {
         match effect {
             theme::Effect::Simple => (),
             theme::Effect::Reverse => self.write(tstyle::NoInvert),
-            theme::Effect::Bold => self.write(tstyle::NoFaint),
+            theme::Effect::Dim | theme::Effect::Bold => {
+                self.write(tstyle::NoFaint)
+            }
             theme::Effect::Blink => self.write(tstyle::NoBlink),
             theme::Effect::Italic => self.write(tstyle::NoItalic),
             theme::Effect::Strikethrough => self.write(tstyle::NoCrossedOut),