code review for gorhill#3328

shuaaaa · Dec 8, 2017 · e83ffde · e83ffde
1 parent c7e8b65
commit e83ffde
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/js/hntrie.js b/src/js/hntrie.js
@@ -188,9 +188,12 @@ HNTrieBuilder.prototype.fromDomainOpt = function(hostnames) {
 };
 
 HNTrieBuilder.prototype.fromIterable = function(hostnames) {
+    var hns = Array.from(hostnames).sort(function(a, b) {
+        return a.length - b.length;
+    });
     // https://github.com/gorhill/uBlock/issues/3328
     //   Must sort from shortest to longest.
-    for ( var hn of hostnames.sort(function(a,b){return a.length-b.length;}) ) {
+    for ( var hn of hns ) {
         this.add(hn);
     }
     return this;