Rename Subscription#reject! to Subscription#reject as there's only on…

…e version of the method
shunyama · Nov 5, 2015 · 37fe489 · 37fe489
1 parent de64aa3
commit 37fe489
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/action_cable/channel/base.rb b/lib/action_cable/channel/base.rb
@@ -76,7 +76,7 @@ module Channel
     #   class ChatChannel < ApplicationCable::Channel
     #     def subscribed
     #       @room = Chat::Room[params[:room_number]]
-    #       reject! unless current_user.can_access?(@room)
+    #       reject unless current_user.can_access?(@room)
     #     end
     #   end
     #
@@ -198,7 +198,7 @@ def subscription_confirmation_sent?
           @subscription_confirmation_sent
         end
 
-        def reject!
+        def reject
           @reject_subscription = true
         end
 

diff --git a/test/channel/rejection_test.rb b/test/channel/rejection_test.rb
@@ -5,7 +5,7 @@
 class ActionCable::Channel::RejectionTest < ActiveSupport::TestCase
   class SecretChannel < ActionCable::Channel::Base
     def subscribed
-      reject! if params[:id] > 0
+      reject if params[:id] > 0
     end
   end