Don't add the current connection to the connections array until after…

… all the callbacks are run
shunyama · Oct 14, 2015 · 773d3c2 · 773d3c2
1 parent af7ddfc
commit 773d3c2
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/action_cable/connection/base.rb b/lib/action_cable/connection/base.rb
@@ -143,13 +143,12 @@ def cookies
         attr_reader :subscriptions, :message_buffer
 
         def on_open
-          server.add_connection(self)
-
           connect if respond_to?(:connect)
           subscribe_to_internal_channel
           beat
 
           message_buffer.process!
+          server.add_connection(self)
         rescue ActionCable::Connection::Authorization::UnauthorizedError
           respond_to_invalid_request
           close