Update listen gem to v3.3

Version 3.3 fixes memory leaks that occur when stopping individual listeners (see guard/listen#476).
shunyama · Nov 10, 2020 · 9e16bb2 · 9e16bb2
1 parent 8435250
commit 9e16bb2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/Gemfile b/Gemfile
@@ -45,7 +45,7 @@ end
 
 # Active Support
 gem "dalli"
-gem "listen", "~> 3.2", require: false, github: "guard/listen"
+gem "listen", "~> 3.3", require: false
 gem "libxml-ruby", platforms: :ruby
 gem "connection_pool", require: false
 gem "rexml", require: false

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -11,14 +11,6 @@ GIT
   specs:
     mysql2 (0.5.3)
 
-GIT
-  remote: https://github.com/guard/listen.git
-  revision: 26f5848feb1fa0d1a754fa3d272a05233e797ea0
-  specs:
-    listen (3.3.0.pre.2)
-      rb-fsevent (~> 0.10, >= 0.10.3)
-      rb-inotify (~> 0.9, >= 0.9.10)
-
 GIT
   remote: https://github.com/matthewd/websocket-client-simple.git
   revision: e161305f1a466b9398d86df3b1731b03362da91b
@@ -315,6 +307,9 @@ GEM
       mustache
       nokogiri
     libxml-ruby (3.2.0)
+    listen (3.3.0)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
     loofah (2.7.0)
       crass (~> 1.0.2)
       nokogiri (>= 1.5.9)
@@ -583,7 +578,7 @@ DEPENDENCIES
   json (>= 2.0.0)
   kindlerb (~> 1.2.0)
   libxml-ruby
-  listen (~> 3.2)!
+  listen (~> 3.3)
   minitest-bisect
   minitest-reporters
   minitest-retry

diff --git a/guides/source/configuring.md b/guides/source/configuring.md
@@ -1755,7 +1755,7 @@ evented file system monitor to detect changes when `config.cache_classes` is
 
 ```ruby
 group :development do
-  gem 'listen', '~> 3.2'
+  gem 'listen', '~> 3.3'
 end
 ```
 

diff --git a/railties/lib/rails/generators/rails/app/templates/Gemfile.tt b/railties/lib/rails/generators/rails/app/templates/Gemfile.tt
@@ -56,7 +56,7 @@ group :development do
   gem 'rack-mini-profiler', '~> 2.0'
 <%- end -%>
 <% if depend_on_listen? -%>
-  gem 'listen', '~> 3.2'
+  gem 'listen', '~> 3.3'
 <% end -%>
 <% if spring_install? -%>
   # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
-Original file line number
+Diff line change
@@ Expand Up @@
     ```ruby
     group :development do
-      gem 'listen', '~> 3.2'
+      gem 'listen', '~> 3.3'
     end
     ```
@@ Expand Down @@