[FLINK-17970] Increase default value of cluster.io-pool.size from #co…

…res to 4 * #cores This closes apache#12360.
shuttie · Jun 2, 2020 · b416302 · b416302
1 parent 3bf3f0c
commit b416302
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docs/_includes/generated/cluster_configuration.html b/docs/_includes/generated/cluster_configuration.html
@@ -18,7 +18,7 @@
             <td><h5>cluster.io-pool.size</h5></td>
             <td style="word-wrap: break-word;">(none)</td>
             <td>Integer</td>
-            <td>The size of the IO executor pool used by the cluster to execute blocking IO operations (Master as well as TaskManager processes). By default it will use the number of CPU cores (hardware contexts) that the cluster process has access to. Increasing the pool size allows to run more IO operations concurrently.</td>
+            <td>The size of the IO executor pool used by the cluster to execute blocking IO operations (Master as well as TaskManager processes). By default it will use 4 * the number of CPU cores (hardware contexts) that the cluster process has access to. Increasing the pool size allows to run more IO operations concurrently.</td>
         </tr>
         <tr>
             <td><h5>cluster.registration.error-delay</h5></td>

diff --git a/docs/_includes/generated/expert_fault_tolerance_section.html b/docs/_includes/generated/expert_fault_tolerance_section.html
@@ -12,7 +12,7 @@
             <td><h5>cluster.io-pool.size</h5></td>
             <td style="word-wrap: break-word;">(none)</td>
             <td>Integer</td>
-            <td>The size of the IO executor pool used by the cluster to execute blocking IO operations (Master as well as TaskManager processes). By default it will use the number of CPU cores (hardware contexts) that the cluster process has access to. Increasing the pool size allows to run more IO operations concurrently.</td>
+            <td>The size of the IO executor pool used by the cluster to execute blocking IO operations (Master as well as TaskManager processes). By default it will use 4 * the number of CPU cores (hardware contexts) that the cluster process has access to. Increasing the pool size allows to run more IO operations concurrently.</td>
         </tr>
         <tr>
             <td><h5>cluster.registration.error-delay</h5></td>

diff --git a/flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java b/flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
@@ -69,7 +69,7 @@ public class ClusterOptions {
 		.intType()
 		.noDefaultValue()
 		.withDescription("The size of the IO executor pool used by the cluster to execute blocking IO operations (Master as well as TaskManager processes). " +
-			"By default it will use the number of CPU cores (hardware contexts) that the cluster process has access to. " +
+			"By default it will use 4 * the number of CPU cores (hardware contexts) that the cluster process has access to. " +
 			"Increasing the pool size allows to run more IO operations concurrently.");
 
 	@Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/util/ClusterEntrypointUtils.java b/flink-runtime/src/main/java/org/apache/flink/runtime/util/ClusterEntrypointUtils.java
@@ -70,7 +70,7 @@ private static File deriveFlinkHomeDirectoryFromLibDirectory() {
 	 * @return The legal io-executor pool size.
 	 */
 	public static int getPoolSize(Configuration config) {
-		final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, Hardware.getNumberCPUCores());
+		final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, 4 * Hardware.getNumberCPUCores());
 		Preconditions.checkArgument(poolSize > 0,
 			String.format("Illegal pool size (%s) of io-executor, please re-configure '%s'.",
 				poolSize, ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE.key()));