Skip to content

Commit

Permalink
Revert "Add elevation and thickness to SemanticsNode (flutter#7282)" (f…
Browse files Browse the repository at this point in the history
…lutter#7483)

This reverts commit 6c29fb4.
  • Loading branch information
goderbauer authored Jan 15, 2019
1 parent 6c29fb4 commit 24cf93e
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 22 deletions.
14 changes: 0 additions & 14 deletions lib/ui/semantics.dart
Original file line number Diff line number Diff line change
Expand Up @@ -607,14 +607,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
///
/// The `transform` is a matrix that maps this node's coordinate system into
/// its parent's coordinate system.
///
/// The `elevation` describes the distance in z-direction between this node
/// and the `elevation` of the parent.
///
/// The `thickness` describes how much space this node occupies in the
/// z-direction starting at `elevation`. Basically, in the z-direction the
/// node starts at `elevation` above the parent and ends at `elevation` +
/// `thickness` above the parent.
void updateNode({
int id,
int flags,
Expand All @@ -626,8 +618,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
double scrollPosition,
double scrollExtentMax,
double scrollExtentMin,
double elevation,
double thickness,
Rect rect,
String label,
String hint,
Expand Down Expand Up @@ -657,8 +647,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
rect.top,
rect.right,
rect.bottom,
elevation,
thickness,
label,
hint,
value,
Expand Down Expand Up @@ -686,8 +674,6 @@ class SemanticsUpdateBuilder extends NativeFieldWrapperClass2 {
double top,
double right,
double bottom,
double elevation,
double thickness,
String label,
String hint,
String value,
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/semantics/semantics_node.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ struct SemanticsNode {
double scrollPosition = std::nan("");
double scrollExtentMax = std::nan("");
double scrollExtentMin = std::nan("");
double elevation = 0.0;
double thickness = 0.0;
std::string label;
std::string hint;
std::string value;
Expand Down
4 changes: 0 additions & 4 deletions lib/ui/semantics/semantics_update_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ void SemanticsUpdateBuilder::updateNode(
double top,
double right,
double bottom,
double elevation,
double thickness,
std::string label,
std::string hint,
std::string value,
Expand All @@ -74,8 +72,6 @@ void SemanticsUpdateBuilder::updateNode(
node.scrollExtentMax = scrollExtentMax;
node.scrollExtentMin = scrollExtentMin;
node.rect = SkRect::MakeLTRB(left, top, right, bottom);
node.elevation = elevation;
node.thickness = thickness;
node.label = label;
node.hint = hint;
node.value = value;
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/semantics/semantics_update_builder.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ class SemanticsUpdateBuilder
double top,
double right,
double bottom,
double elevation,
double thickness,
std::string label,
std::string hint,
std::string value,
Expand Down

0 comments on commit 24cf93e

Please sign in to comment.