Further explained SceneKit hacks and minor stylistic fixes

shuxiashusheng · Nov 3, 2014 · 7fee64d · 7fee64d
1 parent a10d5f9
commit 7fee64d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pop/POPAnimationRuntime.h b/pop/POPAnimationRuntime.h
@@ -27,7 +27,7 @@ enum POPValueType
   kPOPValueRange,
   kPOPValueColor,
   kPOPValueSCNVector3,
-  kPOPValueSCNVector4
+  kPOPValueSCNVector4,
 };
 
 using namespace POP;

diff --git a/pop/POPGeometry.mm b/pop/POPGeometry.mm
@@ -73,11 +73,13 @@ - (CGAffineTransform)CGAffineTransformValue {
 #import <SceneKit/SceneKit.h>
 
 /**
-  Dirty hacks because iOS is stupid and decided to define both SCNVector3's and SCNVector4's objCType as "t". However @encode(SCNVector3) and @encode(SCNVector4) both return the proper definition ("{SCNVector3=fff}" and "{SCNVector4=ffff}" respectively)
+  Dirty hacks because iOS is weird and decided to define both SCNVector3's and SCNVector4's objCType as "t". However @encode(SCNVector3) and @encode(SCNVector4) both return the proper definition ("{SCNVector3=fff}" and "{SCNVector4=ffff}" respectively)
+ 
+  [[NSValue valueWithSCNVector3:SCNVector3Make(0.0, 0.0, 0.0)] objcType] returns "t", whereas it should return "{SCNVector3=fff}".
  
   *flips table*
  */
-@implementation NSValue (SceneKitFU)
+@implementation NSValue (SceneKitFixes)
 
 + (NSValue *)valueWithSCNVector3:(SCNVector3)vec3 {
   return [NSValue valueWithBytes:&vec3 objCType:@encode(SCNVector3)];