Fix msgrcv #3
Merged
Fix msgrcv #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ccussaguet, thanks for this PR! It would be great if you could you add a test in msgrcv_test.go for the failing case you wrote about. This will help prevent us from reverting back to the previous state by mistake. Also, what do you suggest would be a more descriptive name for the new r1 variable? Cheers :) |
|
Great job! Thanks! 👍 |
|
You're welcome. Now the remaining thing to do is to remove the bufSize const variable (which is too low) and calculate it dynamically using SYS_MSGCTL. I'm working on it but I'm facing a wall for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I modified the msgrcv.go file to use the r1 output which is the length read by the syscall.SYS_MSGRCV. It was working with only string because when I used byte array with 0x00 in it the msgrcv method would stopped before reading the entire message.