[Major bug] Fix self.authorized return if we need to self._authorize #16
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we need to re-authorize (after 23 hrs),
self._authorize
works fine andself.auth_token
is refreshed but we end up not returning anything inself.authorized
!If nothing is returned, Python defaults to
None
. This will causemake_request
to raiseB2AuthorizationError('Unknown Error')
whenever we need to re-authorize becauseif self.authorized
evaluates toFalse
.I would say this is a pretty major bug because if you are instantiating B2 once on startup, after 23 hrs passes and we need to re-authorize for a new request,
make_request
will fail.