CommitBear: Change regex for issue id

This changes regex for issue id to allow only numeric reference for issue number. Closes coala#2469
siddhpant · May 24, 2018 · 9332d3d · 9332d3d
1 parent 51441bd
commit 9332d3d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/bears/vcs/CommitBear.py b/bears/vcs/CommitBear.py
@@ -24,12 +24,12 @@ class _CommitBear(GlobalBear):
     CAN_DETECT = {'Formatting'}
     ISSUE_INFO = {
         'github': {
-            'issue': r'(?:\w+/\w+)?#(\S+)',
-            'full issue': r'https?://github\S+/issues/(\S+)',
+            'issue': r'(?:\w+/\w+)?#(\d+)',
+            'full issue': r'https?://github\S+/issues/(\d+)',
         },
         'gitlab': {
-            'issue': r'(?:\w+/\w+)?#(\S+)',
-            'full issue': r'https?://gitlab\S+/issues/(\S+)',
+            'issue': r'(?:\w+/\w+)?#(\d+)',
+            'full issue': r'https?://gitlab\S+/issues/(\d+)',
         },
         'bitbucket': {
             'issue': r'#(\d+)',

diff --git a/tests/vcs/git/GitCommitBearTest.py b/tests/vcs/git/GitCommitBearTest.py
@@ -504,7 +504,7 @@ def test_check_issue_reference(self):
         self.assertEqual(self.run_uut(
                              body_close_issue=True,
                              body_close_issue_full_url=True),
-                         ['Invalid issue number: '
+                         ['Invalid full issue reference: '
                           'https://gitlab.com/user/repo/issues/not_num'])
         self.assert_no_msgs()
 
@@ -526,7 +526,7 @@ def test_check_issue_reference(self):
                         'Another line, blablablablablabla.\n'
                         'Resolve #11 and close #notnum')
         self.assertEqual(self.run_uut(body_close_issue=True,),
-                         ['Invalid issue number: #notnum'])
+                         ['Invalid issue reference: #notnum'])
         self.assert_no_msgs()
 
         # Close issues in other repos