Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency wheel #71

Conversation

HerrMuellerluedenscheid
Copy link

@HerrMuellerluedenscheid HerrMuellerluedenscheid commented Nov 8, 2021

Cloned and tried installing on a fresh image inside a venv under python3.8. Dependency wheel was missing.

Signed-off-by: Marius Kriegerowski [email protected]

Signed-off-by: Marius Kriegerowski <[email protected]>
@jan-kiszka
Copy link
Collaborator

Good catch. But please also define reasonable lower and upper version limits. Bonus for routing the patch via the mailing list.

@jan-kiszka
Copy link
Collaborator

Ping.

@jan-kiszka
Copy link
Collaborator

Actually, I'm no longer sure this belongs into setup.py. Don't we rather need a pyproject.toml? See https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use.

@jan-kiszka
Copy link
Collaborator

Should be resolved by 412241b.

@jan-kiszka jan-kiszka closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants