Skip to content

Commit

Permalink
runtime: skip test that intermittently hangs on ppc64le
Browse files Browse the repository at this point in the history
A new testcase TestSelectFairness was recently added, and
since then the ppc64le build tests have intermittently failed.

This adds a change to skip this test on ppc64le using
SkipFlaky to help determine if the problem is with the
test or something else with that commit.

Updates golang#22047

Change-Id: Idfef72ed791c5bd45c42ff180947fea3df280ea7
Reviewed-on: https://go-review.googlesource.com/67631
Run-TryBot: Lynn Boger <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
  • Loading branch information
laboger committed Oct 3, 2017
1 parent 41eabc0 commit f47c8f1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/runtime/chan_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package runtime_test

import (
"internal/testenv"
"math"
"runtime"
"sync"
Expand Down Expand Up @@ -433,6 +434,9 @@ func TestSelectStress(t *testing.T) {

func TestSelectFairness(t *testing.T) {
const trials = 10000
if runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le" {
testenv.SkipFlaky(t, 22047)
}
c1 := make(chan byte, trials+1)
c2 := make(chan byte, trials+1)
for i := 0; i < trials+1; i++ {
Expand Down

0 comments on commit f47c8f1

Please sign in to comment.