Prefer to throw an Error rather than returning a null value which _wi…

…ll_ eventually lead to a NullPointerException
sigtool · Apr 18, 2014 · ad3ccf0 · ad3ccf0
1 parent 8523184
commit ad3ccf0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/core/src/main/java/fi/iki/elonen/NanoHTTPD.java b/core/src/main/java/fi/iki/elonen/NanoHTTPD.java
@@ -1201,7 +1201,7 @@ private String saveTmpFile(ByteBuffer b, int offset, int len) {
                     dest.write(src.slice());
                     path = tempFile.getName();
                 } catch (Exception e) { // Catch exception if any
-                    System.err.println("Error: " + e.getMessage());
+                    throw new Error(e); // we won't recover, so throw an error
                 } finally {
                     safeClose(fileOutputStream);
                 }
@@ -1214,9 +1214,8 @@ private RandomAccessFile getTmpBucket() {
                 TempFile tempFile = tempFileManager.createTempFile();
                 return new RandomAccessFile(tempFile.getName(), "rw");
             } catch (Exception e) {
-                System.err.println("Error: " + e.getMessage());
+            	throw new Error(e); // we won't recover, so throw an error
             }
-            return null;
         }
 
         /**