[hotfix] Make all converters @internal

silenceland · Sep 17, 2021 · 7a6bca8 · 7a6bca8
1 parent 463a7d4
commit 7a6bca8
Show file tree

Hide file tree

Showing 22 changed files with 44 additions and 0 deletions.
diff --git a/.../java/org/apache/flink/table/planner/expressions/converter/converters/ArrayConverter.java b/.../java/org/apache/flink/table/planner/expressions/converter/converters/ArrayConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -31,6 +32,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#ARRAY}. */
+@Internal
 class ArrayConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...ain/java/org/apache/flink/table/planner/expressions/converter/converters/AsConverter.java b/...ain/java/org/apache/flink/table/planner/expressions/converter/converters/AsConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.ValueLiteralExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
@@ -28,6 +29,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.extractValue;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#AS}. */
+@Internal
 class AsConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...ava/org/apache/flink/table/planner/expressions/converter/converters/BetweenConverter.java b/...ava/org/apache/flink/table/planner/expressions/converter/converters/BetweenConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -30,6 +31,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#BETWEEN}. */
+@Internal
 class BetweenConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...n/java/org/apache/flink/table/planner/expressions/converter/converters/CastConverter.java b/...n/java/org/apache/flink/table/planner/expressions/converter/converters/CastConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.TypeLiteralExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
@@ -27,6 +28,7 @@
 import org.apache.calcite.rex.RexNode;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#CAST}. */
+@Internal
 class CastConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...in/java/org/apache/flink/table/planner/expressions/converter/converters/GetConverter.java b/...in/java/org/apache/flink/table/planner/expressions/converter/converters/GetConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.ExpressionUtils;
 import org.apache.flink.table.expressions.ValueLiteralExpression;
@@ -31,6 +32,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.extractValue;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#GET}. */
+@Internal
 class GetConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...ain/java/org/apache/flink/table/planner/expressions/converter/converters/InConverter.java b/...ain/java/org/apache/flink/table/planner/expressions/converter/converters/InConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.Expression;
 import org.apache.flink.table.expressions.TableReferenceExpression;
@@ -35,6 +36,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#IN}. */
+@Internal
 class InConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...java/org/apache/flink/table/planner/expressions/converter/converters/IsJsonConverter.java b/...java/org/apache/flink/table/planner/expressions/converter/converters/IsJsonConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.api.JsonType;
 import org.apache.flink.table.api.TableException;
 import org.apache.flink.table.expressions.CallExpression;
@@ -30,6 +31,7 @@
 import org.apache.calcite.sql.SqlOperator;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#IS_JSON}. */
+@Internal
 class IsJsonConverter extends CustomizedConverter {
 
     @Override

diff --git a/.../org/apache/flink/table/planner/expressions/converter/converters/JsonExistsConverter.java b/.../org/apache/flink/table/planner/expressions/converter/converters/JsonExistsConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.api.JsonExistsOnError;
 import org.apache.flink.table.api.TableException;
 import org.apache.flink.table.expressions.CallExpression;
@@ -33,6 +34,7 @@
 import java.util.List;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#JSON_EXISTS}. */
+@Internal
 class JsonExistsConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...a/org/apache/flink/table/planner/expressions/converter/converters/JsonQueryConverter.java b/...a/org/apache/flink/table/planner/expressions/converter/converters/JsonQueryConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.api.JsonQueryOnEmptyOrError;
 import org.apache.flink.table.api.JsonQueryWrapper;
 import org.apache.flink.table.api.TableException;
@@ -35,6 +36,7 @@
 import java.util.List;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#JSON_QUERY}. */
+@Internal
 class JsonQueryConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...a/org/apache/flink/table/planner/expressions/converter/converters/JsonValueConverter.java b/...a/org/apache/flink/table/planner/expressions/converter/converters/JsonValueConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.api.JsonValueOnEmptyOrError;
 import org.apache.flink.table.api.TableException;
 import org.apache.flink.table.expressions.CallExpression;
@@ -40,6 +41,7 @@
 import static org.apache.flink.table.planner.utils.ShortcutUtils.unwrapTypeFactory;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#JSON_VALUE}. */
+@Internal
 class JsonValueConverter extends CustomizedConverter {
 
     @Override

diff --git a/...in/java/org/apache/flink/table/planner/expressions/converter/converters/MapConverter.java b/...in/java/org/apache/flink/table/planner/expressions/converter/converters/MapConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.Expression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
@@ -32,6 +33,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#MAP}. */
+@Internal
 class MapConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/.../org/apache/flink/table/planner/expressions/converter/converters/NotBetweenConverter.java b/.../org/apache/flink/table/planner/expressions/converter/converters/NotBetweenConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -30,6 +31,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#NOT_BETWEEN}. */
+@Internal
 class NotBetweenConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...va/org/apache/flink/table/planner/expressions/converter/converters/OrderAscConverter.java b/...va/org/apache/flink/table/planner/expressions/converter/converters/OrderAscConverter.java
@@ -18,13 +18,15 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
 
 import org.apache.calcite.rex.RexNode;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#ORDER_ASC}. */
+@Internal
 class OrderAscConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...n/java/org/apache/flink/table/planner/expressions/converter/converters/PlusConverter.java b/...n/java/org/apache/flink/table/planner/expressions/converter/converters/PlusConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -35,6 +36,7 @@
 import static org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isTimeInterval;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#PLUS}. */
+@Internal
 class PlusConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...apache/flink/table/planner/expressions/converter/converters/ReinterpretCastConverter.java b/...apache/flink/table/planner/expressions/converter/converters/ReinterpretCastConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.TypeLiteralExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
@@ -26,6 +27,7 @@
 import org.apache.calcite.rex.RexNode;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#REINTERPRET_CAST}. */
+@Internal
 class ReinterpretCastConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...ava/org/apache/flink/table/planner/expressions/converter/converters/ReplaceConverter.java b/...ava/org/apache/flink/table/planner/expressions/converter/converters/ReplaceConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.Expression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
@@ -31,6 +32,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#REPLACE}. */
+@Internal
 class ReplaceConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...in/java/org/apache/flink/table/planner/expressions/converter/converters/RowConverter.java b/...in/java/org/apache/flink/table/planner/expressions/converter/converters/RowConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -31,6 +32,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#ROW}. */
+@Internal
 class RowConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...n/java/org/apache/flink/table/planner/expressions/converter/converters/SqrtConverter.java b/...n/java/org/apache/flink/table/planner/expressions/converter/converters/SqrtConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.ApiExpressionUtils;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
@@ -31,6 +32,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#SQRT}. */
+@Internal
 class SqrtConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...pache/flink/table/planner/expressions/converter/converters/TemporalOverlapsConverter.java b/...pache/flink/table/planner/expressions/converter/converters/TemporalOverlapsConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -32,6 +33,7 @@
 import static org.apache.flink.table.runtime.typeutils.TypeCheckUtils.isTimeInterval;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#TEMPORAL_OVERLAPS}. */
+@Internal
 class TemporalOverlapsConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/.../apache/flink/table/planner/expressions/converter/converters/ThrowExceptionConverter.java b/.../apache/flink/table/planner/expressions/converter/converters/ThrowExceptionConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.TypeLiteralExpression;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -30,6 +31,7 @@
 import static org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromDataTypeToLogicalType;
 
 /** Conversion for {@link InternalFunctionDefinitions#THROW_EXCEPTION}. */
+@Internal
 class ThrowExceptionConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...g/apache/flink/table/planner/expressions/converter/converters/TimestampDiffConverter.java b/...g/apache/flink/table/planner/expressions/converter/converters/TimestampDiffConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.functions.BuiltInFunctionDefinitions;
 import org.apache.flink.table.planner.expressions.converter.CallExpressionConvertRule;
@@ -30,6 +31,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.toRexNodes;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#TIMESTAMP_DIFF}. */
+@Internal
 class TimestampDiffConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {

diff --git a/...n/java/org/apache/flink/table/planner/expressions/converter/converters/TrimConverter.java b/...n/java/org/apache/flink/table/planner/expressions/converter/converters/TrimConverter.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.table.planner.expressions.converter.converters;
 
+import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.expressions.CallExpression;
 import org.apache.flink.table.expressions.Expression;
 import org.apache.flink.table.expressions.ValueLiteralExpression;
@@ -33,6 +34,7 @@
 import static org.apache.flink.table.planner.expressions.converter.ExpressionConverter.extractValue;
 
 /** Conversion for {@link BuiltInFunctionDefinitions#TRIM}. */
+@Internal
 class TrimConverter extends CustomizedConverter {
     @Override
     public RexNode convert(CallExpression call, CallExpressionConvertRule.ConvertContext context) {