Skip to content

Commit

Permalink
[FLINK-6803] [tests] Fully enable PojoSerializerUpgradeTests for all …
Browse files Browse the repository at this point in the history
…state backends

With the fixes for the PojoSerializer in, this commit fully enables all
tests for upgrading the PojoSerializer for all state backends, which
otherwise could not pass before.

This closes apache#4044.
  • Loading branch information
tzulitai committed Jun 13, 2017
1 parent f0f2e99 commit 8b26460
Showing 1 changed file with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import org.apache.flink.api.java.functions.KeySelector;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.CoreOptions;
import org.apache.flink.contrib.streaming.state.RocksDBStateBackend;
import org.apache.flink.core.testutils.CommonTestUtils;
import org.apache.flink.runtime.operators.testutils.MockEnvironment;
import org.apache.flink.runtime.operators.testutils.MockInputSplitProvider;
Expand All @@ -52,7 +51,6 @@
import org.apache.flink.util.StateMigrationException;
import org.apache.flink.util.TestLogger;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.junit.runner.RunWith;
Expand All @@ -74,7 +72,6 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.junit.Assume.assumeTrue;

@RunWith(Parameterized.class)
public class PojoSerializerUpgradeTest extends TestLogger {
Expand Down Expand Up @@ -181,7 +178,6 @@ public void testChangedFieldOrderWithKeyedState() throws Exception {
/**
* We should be able to handle a changed field order of a POJO as operator state
*/
@Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testChangedFieldOrderWithOperatorState() throws Exception {
testPojoSerializerUpgrade(SOURCE_A, SOURCE_B, true, false);
Expand All @@ -192,7 +188,6 @@ public void testChangedFieldOrderWithOperatorState() throws Exception {
*/
@Test
public void testChangedFieldTypesWithKeyedState() throws Exception {
assumeTrue("Running only for RocksDBStateBackend until FLINK-6804 has been fixed.", stateBackend instanceof RocksDBStateBackend);
try {
testPojoSerializerUpgrade(SOURCE_A, SOURCE_C, true, true);
fail("Expected a state migration exception.");
Expand All @@ -208,7 +203,6 @@ public void testChangedFieldTypesWithKeyedState() throws Exception {
/**
* Changing field types of a POJO as operator state should require a state migration
*/
@Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testChangedFieldTypesWithOperatorState() throws Exception {
try {
Expand All @@ -228,7 +222,6 @@ public void testChangedFieldTypesWithOperatorState() throws Exception {
*/
@Test
public void testAdditionalFieldWithKeyedState() throws Exception {
assumeTrue("Running only for RocksDBStateBackend until FLINK-6804 has been fixed.", stateBackend instanceof RocksDBStateBackend);
try {
testPojoSerializerUpgrade(SOURCE_A, SOURCE_D, true, true);
fail("Expected a state migration exception.");
Expand All @@ -244,7 +237,6 @@ public void testAdditionalFieldWithKeyedState() throws Exception {
/**
* Adding fields to a POJO as operator state should require a state migration
*/
@Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testAdditionalFieldWithOperatorState() throws Exception {
try {
Expand All @@ -262,7 +254,6 @@ public void testAdditionalFieldWithOperatorState() throws Exception {
/**
* Removing fields from a POJO as keyed state should require a state migration
*/
@Ignore("Ignore this test until FLINK-6801 has been fixed.")
@Test
public void testMissingFieldWithKeyedState() throws Exception {
try {
Expand All @@ -280,7 +271,6 @@ public void testMissingFieldWithKeyedState() throws Exception {
/**
* Removing fields from a POJO as operator state should require a state migration
*/
@Ignore("Ignore this test until FLINK-6804 has been fixed.")
@Test
public void testMissingFieldWithOperatorState() throws Exception {
try {
Expand Down

0 comments on commit 8b26460

Please sign in to comment.