Skip to content

Commit

Permalink
Fixed logging from jest3s library.
Browse files Browse the repository at this point in the history
I fixed the same issue already 6months ago,
but some of last changes in build.sh deleted copy
of java/src/resource into h2o.jar.

Hence, jest3s library was not properly configured
and outputed all debug content into logs.
  • Loading branch information
mmalohlava committed Nov 27, 2013
1 parent cc1a54a commit 71c888b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
5 changes: 5 additions & 0 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ function build_classes() {
$SRC/jsr166y/*java \
$TESTSRC/*/*java \
$TESTSRC/*/*/*java

# Copy Java resources
# If you delete this line you take responsibility for logging and you have to make
# sure that jests3 library will not output its logs into our log files !!!
cp -r ${RESOURCES}/* "${CLASSES}"
}

function build_initializer() {
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/water/util/Log.java
Original file line number Diff line number Diff line change
Expand Up @@ -332,17 +332,17 @@ private static org.apache.log4j.Logger createLog4jLogger(String logDirParent) {
p.setProperty("log4j.appender.R.MaxBackupIndex", "5");
p.setProperty("log4j.appender.R.layout", "org.apache.log4j.PatternLayout");

// Turn down the logging for some class hierarchies.
// Turn down the logging for some class hierarchies.
p.setProperty("log4j.logger.org.apache.http", "WARN");
p.setProperty("log4j.logger.com.amazonaws", "WARN");
p.setProperty("log4j.logger.org.apache.hadoop", "WARN");
p.setProperty("log4j.logger.org.jets3t.service", "WARN");

// See the following document for information about the pattern layout.
// http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html
//
// Uncomment this line to find the source of unwanted messages.
//
// Uncomment this line to find the source of unwanted messages.
// p.setProperty("log4j.appender.R.layout.ConversionPattern", "%p %C %m%n");
//
p.setProperty("log4j.appender.R.layout.ConversionPattern", "%m%n");

PropertyConfigurator.configure(p);
Expand Down
1 change: 0 additions & 1 deletion src/main/resources/version.properties

This file was deleted.

0 comments on commit 71c888b

Please sign in to comment.