reorder a constant/missing comparison

silicosapiens · Jul 26, 2013 · ef7b031 · ef7b031
1 parent a37a080
commit ef7b031
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/py/h2o_glm.py b/py/h2o_glm.py
@@ -326,12 +326,7 @@ def goodXFromColumnInfo(y,
             x.remove(k)
             ignore_x.append(k)
 
-        elif k in constantValuesDict:
-            value = constantValuesDict[k]
-            print "Removing %d with name: %s because it has constant value: %s " % (k, name, str(value))
-            x.remove(k)
-            ignore_x.append(k)
-
+        # missing values reports as constant also. so do missing first.
         # remove all cols with missing values
         # could change it against num_rows for a ratio
         elif k in missingValuesDict:
@@ -340,6 +335,12 @@ def goodXFromColumnInfo(y,
             x.remove(k)
             ignore_x.append(k)
 
+        elif k in constantValuesDict:
+            value = constantValuesDict[k]
+            print "Removing %d with name: %s because it has constant value: %s " % (k, name, str(value))
+            x.remove(k)
+            ignore_x.append(k)
+
         # this is extra pruning..
         # remove all cols with enums, if not already removed
         elif k in enumSizeDict: