Remove redundant flag (-O) registration (fixes #13392)

Reviewers: austin, bgamari, dfeuer Reviewed By: bgamari, dfeuer Subscribers: rwbarton, thomie GHC Trac Issues: #13392 Differential Revision: https://phabricator.haskell.org/D3461
silky · Apr 18, 2017 · b894f02 · b894f02
1 parent 5a21003
commit b894f02
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/compiler/main/DynFlags.hs b/compiler/main/DynFlags.hs
@@ -3141,7 +3141,6 @@ dynamic_flags_deps = [
   , make_ord_flag defGhcFlag "ffrontend-opt" (hasArg addFrontendPluginOption)
 
         ------ Optimisation flags ------------------------------------------
-  , make_ord_flag defGhcFlag "O"      (noArgM (setOptLevel 1))
   , make_dep_flag defGhcFlag "Onot"   (noArgM $ setOptLevel 0 )
                                                             "Use -O0 instead"
   , make_ord_flag defGhcFlag "Odph"   (noArgM setDPHOpt)

diff --git a/testsuite/tests/driver/T13392/Makefile b/testsuite/tests/driver/T13392/Makefile
@@ -0,0 +1,6 @@
+TOP=../../..
+include $(TOP)/mk/boilerplate.mk
+include $(TOP)/mk/test.mk
+
+T13392:
+	'$(TEST_HC)' $(TEST_HC_OPTS) --show-options | sort | uniq -d
diff --git a/testsuite/tests/driver/T13392/T13392.stdout b/testsuite/tests/driver/T13392/T13392.stdout
diff --git a/testsuite/tests/driver/T13392/all.T b/testsuite/tests/driver/T13392/all.T
@@ -0,0 +1,3 @@
+# Test for #13392, it makes sure 'ghc --show-options' does not print each flag more than once.
+
+test('T13392', normal, run_command, ['$MAKE -s --no-print-directory T13392'])
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		# Test for #13392, it makes sure 'ghc --show-options' does not print each flag more than once.

		test('T13392', normal, run_command, ['$MAKE -s --no-print-directory T13392'])