404 instead of boilerplate on production JS links

Make sure the 404 is not cached. Helps with CDNs (see eg 6ff0faa).
simajq · Aug 31, 2015 · a0162f2 · a0162f2
1 parent 8b13ffb
commit a0162f2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/webapp/webapp_server.js b/packages/webapp/webapp_server.js
@@ -672,6 +672,17 @@ var runWebAppServer = function () {
       return undefined;
     }
 
+    if (request.url.query && request.url.query['meteor_js_resource']) {
+      // Similarly, we're requesting a JS resource that we don't have.
+      // Serve an uncached 404. (We can't use the same hack we use for CSS,
+      // because actually acting on that hack requires us to have the JS
+      // already!)
+      headers['Cache-Control'] = 'no-cache';
+      res.writeHead(404, headers);
+      res.end("404 Not Found");
+      return undefined;
+    }
+
     // /packages/asdfsad ... /__cordova/dafsdf.js
     var pathname = connect.utils.parseUrl(req).pathname;
     var archKey = pathname.split('/')[1];

diff --git a/tools/isobuild/bundler.js b/tools/isobuild/bundler.js
@@ -865,7 +865,7 @@ class Target {
           newFile.setUrlFromRelPath(file.path);
           newFile.targetPath = file.path;
         } else {
-          newFile.setUrlToHash('.js');
+          newFile.setUrlToHash('.js', '?meteor_js_resource=true');
         }
 
         return newFile;