code added check valid arguments for glob, test added as well

Testing Done:
added 2 tests on invalid argument and all glob tests passed.

intend to rewrite the test to include checking exception messages.

Bugs closed: 2126

Reviewed at https://rbcommons.com/s/twitter/r/2750/

src/python/pants/backend/core/wrapped_globs.py

@@ -54,6 +54,7 @@ def __getitem__(self, index):
 
 
 class FilesetRelPathWrapper(object):
+  KNOWN_PARAMETERS = frozenset(['exclude', 'follow_links'])
 
   @classmethod
   @manual.builddict(factory=True)
@@ -71,8 +72,15 @@ def __call__(self, *args, **kwargs):
     root = os.path.normpath(os.path.join(get_buildroot(), self._rel_path))
 
     excludes = kwargs.pop('exclude', [])
+
     if isinstance(excludes, string_types):
-        raise ValueError("Expected exclude parameter to be a list of globs, lists, or strings")
+      raise ValueError("Expected exclude parameter to be a list of globs, lists, or strings")
+
+    # making sure there is no unknown argument(s)
+    unknown_args = set(kwargs.keys()) - self.KNOWN_PARAMETERS
+
+    if unknown_args:
+      raise ValueError('Unexpected arguments while parsing globs: {}'.format(', '.join(unknown_args)))
 
     for i, exclude in enumerate(excludes):
       if isinstance(exclude, string_types):

tests/python/pants_test/backend/core/test_wrapped_globs.py

@@ -113,6 +113,16 @@ def test_glob_exclude_string_in_list(self):
     self.add_to_build_file('y/BUILD', 'java_library(name="y", sources=globs("*.java", exclude=["fleem.java"]))')
     self.context().scan(self.build_root)
 
+  def test_glob_invalid_keyword(self):
+    self.add_to_build_file('y/BUILD', 'java_library(name="y", sources=globs("*.java", invalid_keyword=["fleem.java"]))')
+    with self.assertRaises(AddressLookupError):
+      self.context().scan(self.build_root)
+
+  def test_glob_invalid_keyword_along_with_valid_ones(self):
+    self.add_to_build_file('y/BUILD', 'java_library(name="y", sources=globs("*.java", follow_links=True, invalid_keyword=["fleem.java"]))')
+    with self.assertRaises(AddressLookupError):
+      self.context().scan(self.build_root)
+
   def test_subdir_glob(self):
     self.add_to_build_file('y/BUILD', 'java_library(name="y", sources=globs("dir/*.scala"))')
     self.context().scan(self.build_root)