autofs: fix a leak in autofs_expire_indirect()

if the second call of should_expire() in there ends up grabbing and returning a new reference to dentry, we need to drop it before continuing. Signed-off-by: Al Viro <[email protected]>
simonjhall · Oct 25, 2019 · 03ad0d7 · 03ad0d7
1 parent 97eba80
commit 03ad0d7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c
@@ -459,9 +459,10 @@ static struct dentry *autofs_expire_indirect(struct super_block *sb,
 		 */
 		how &= ~AUTOFS_EXP_LEAVES;
 		found = should_expire(expired, mnt, timeout, how);
-		if (!found || found != expired)
-			/* Something has changed, continue */
+		if (found != expired) { // something has changed, continue
+			dput(found);
 			goto next;
+		}
 
 		if (expired != dentry)
 			dput(dentry);