Skip to content

Commit

Permalink
afs: Fix possible assert with callbacks from yfs servers
Browse files Browse the repository at this point in the history
Servers sending callback breaks to the YFS_CM_SERVICE service may
send up to YFSCBMAX (1024) fids in a single RPC.  Anything over
AFSCBMAX (50) will cause the assert in afs_break_callbacks to trigger.

Remove the assert, as the count has already been checked against
the appropriate max values in afs_deliver_cb_callback and
afs_deliver_yfs_cb_callback.

Fixes: 35dbfba ("afs: Implement the YFS cache manager service")
Signed-off-by: Marc Dionne <[email protected]>
Signed-off-by: David Howells <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Marc Dionne authored and torvalds committed Nov 22, 2019
1 parent cc07903 commit cd34070
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/afs/callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ void afs_break_callbacks(struct afs_server *server, size_t count,
_enter("%p,%zu,", server, count);

ASSERT(server != NULL);
ASSERTCMP(count, <=, AFSCBMAX);

/* TODO: Sort the callback break list by volume ID */

Expand Down

0 comments on commit cd34070

Please sign in to comment.