Skip to content

Commit

Permalink
Removed PHPSimpleXML dependency
Browse files Browse the repository at this point in the history
It is not used anymore since ListDiff get ported to DOMDocument, so we can get rid of it
  • Loading branch information
Sven Hagemann committed Jan 27, 2021
1 parent b395cbc commit c946d79
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ php-htmldiff is available under [GNU General Public License, version 2][gnu]. Se
* Performance improvements (we have 1 benchmark test, we should probably get more)
* Algorithm improvements - trimming alike text at start and ends, store nested diff results in memory to re-use (like we do w/ caching)
* Benchmark using DOMDocument vs. alternatives vs. string parsing
* Consider not using string parsing for HtmlDiff in order to avoid having to create many DOMDocument instances in ListDiff and TableDiff
* Benchmarking
* Look into removing dependency on php-simple-html-dom-parser library - possibly find alternative or no library at all. Consider how this affects performance.
* Refactoring (but... tests first)
* Overall design/architecture improvements
* API improvements so a new HtmlDiff isn't required for each new diff (especially so that configuration can be re-used)
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"require": {
"php": ">=7.3",
"ezyang/htmlpurifier": "^4.7",
"kub-at/php-simple-html-dom-parser": "^1.7"
"ext-dom": "*",
"ext-mbstring": "*"
},
"require-dev": {
"phpunit/phpunit": "~9.0",
Expand Down

0 comments on commit c946d79

Please sign in to comment.