Skip to content

Commit

Permalink
Remove Local Version Identifier (pytorch#1631)
Browse files Browse the repository at this point in the history
Summary:
- Remove local version identifier from build versioning
- Use CPU-only instances for CPU-only tests

Pull Request resolved: pytorch#1631

Reviewed By: shintaro-iwasaki

Differential Revision: D43915104

Pulled By: q10

fbshipit-source-id: 223845c1c38d911f650d5db926aa7f2f59561b85
  • Loading branch information
q10 authored and facebook-github-bot committed Mar 8, 2023
1 parent 9e343d1 commit 8616ed7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/scripts/setup_env.bash
Original file line number Diff line number Diff line change
Expand Up @@ -963,6 +963,10 @@ __build_fbgemm_gpu_common_pre_steps () {
echo "[BUILD] Running pre-build cleanups ..."
print_exec rm -rf dist
print_exec conda run -n "${env_name}" python setup.py clean

echo "[BUILD] Printing git status ..."
print_exec git status
print_exec git diff
}

check_fbgemm_gpu_build () {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fbgemm_nightly_build_cpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ linux.g5.4xlarge.nvidia.gpu ]
os: [ linux.4xlarge ]
python-version: [ "3.8", "3.9", "3.10" ]
needs: build_artifact

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fbgemm_release_build_cpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ linux.g5.4xlarge.nvidia.gpu ]
os: [ linux.4xlarge ]
python-version: [ "3.8", "3.9", "3.10" ]
needs: build_artifact

Expand Down
3 changes: 2 additions & 1 deletion fbgemm_gpu/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ def generate_package_version(package_name: str):
print(
f"[SETUP.PY] TAG: {gitversion.get_tag()}, BRANCH: {gitversion.get_branch()}, SHA: {gitversion.get_sha()}"
)
version = gitversion.version_from_git()
# Remove the local version identifier, if any (0.4.0rc0.post0+git.6a63116c.dirty => 0.4.0rc0.post0)
version = gitversion.version_from_git().split("+")[0]

print(f"[SETUP.PY] Setting the package version: {version}")
return version
Expand Down

0 comments on commit 8616ed7

Please sign in to comment.