Skip to content

Commit

Permalink
dt-bindings: ufs: qcom: document SC7180 UFS
Browse files Browse the repository at this point in the history
Document already upstreamed and used Qualcomm SC7180 UFS host controller
to fix dtbs_check warnings like:

  sc7180-idp.dtb: ufshc@1d84000: compatible:0: 'qcom,sc7180-ufshc' is not one of ...
  sc7180-idp.dtb: ufshc@1d84000: clocks: [[39, 99], [39, 7], [39, 98], [39, 107], [36, 0], [39, 106], [39, 105]] is too short
  sc7180-idp.dtb: ufshc@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', ...] is too short

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Rob Herring <[email protected]>
  • Loading branch information
krzk authored and robherring committed Mar 27, 2024
1 parent ad91c1d commit 7fb5aaf
Showing 1 changed file with 30 additions and 4 deletions.
34 changes: 30 additions & 4 deletions Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ properties:
- qcom,msm8996-ufshc
- qcom,msm8998-ufshc
- qcom,sa8775p-ufshc
- qcom,sc7180-ufshc
- qcom,sc7280-ufshc
- qcom,sc8180x-ufshc
- qcom,sc8280xp-ufshc
Expand All @@ -43,11 +44,11 @@ properties:
- const: jedec,ufs-2.0

clocks:
minItems: 8
minItems: 7
maxItems: 11

clock-names:
minItems: 8
minItems: 7
maxItems: 11

dma-coherent: true
Expand Down Expand Up @@ -113,6 +114,31 @@ required:
allOf:
- $ref: ufs-common.yaml

- if:
properties:
compatible:
contains:
enum:
- qcom,sc7180-ufshc
then:
properties:
clocks:
minItems: 7
maxItems: 7
clock-names:
items:
- const: core_clk
- const: bus_aggr_clk
- const: iface_clk
- const: core_clk_unipro
- const: ref_clk
- const: tx_lane0_sync_clk
- const: rx_lane0_sync_clk
reg:
maxItems: 1
reg-names:
maxItems: 1

- if:
properties:
compatible:
Expand Down Expand Up @@ -250,15 +276,15 @@ allOf:
reg:
maxItems: 1
clocks:
minItems: 8
minItems: 7
maxItems: 8
else:
properties:
reg:
minItems: 1
maxItems: 2
clocks:
minItems: 8
minItems: 7
maxItems: 11

unevaluatedProperties: false
Expand Down

0 comments on commit 7fb5aaf

Please sign in to comment.