Modify tests; add a message for validation loops

Signed-off-by: Francis Galiegue <[email protected]>
sivashankari2i · May 25, 2014 · 5d8a29d · 5d8a29d
1 parent 2d38847
commit 5d8a29d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/main/resources/com/github/fge/jsonschema/validator/validation.properties b/src/main/resources/com/github/fge/jsonschema/validator/validation.properties
@@ -74,3 +74,8 @@ err.format.jsonpointer.invalid = input string "%s" is not a valid JSON Pointer
 err.format.macAddr.invalid = input string "%s" is not a valid MAC address
 err.format.uriTemplate.invalid = input string "%s" is not a valid URI template
 err.format.UUID.invalid = input string "%s" is not a valid UUID
+
+#
+# Other messages
+#
+err.common.validationLoop = validation loop detected
diff --git a/src/test/java/com/github/fge/jsonschema/processors/validation/ValidationProcessorTest.java b/src/test/java/com/github/fge/jsonschema/processors/validation/ValidationProcessorTest.java
@@ -41,8 +41,10 @@
 import com.github.fge.jsonschema.library.Library;
 import com.github.fge.jsonschema.main.JsonSchemaFactory;
 import com.github.fge.jsonschema.main.JsonValidator;
+import com.github.fge.jsonschema.messages.JsonSchemaValidationBundle;
 import com.github.fge.jsonschema.processors.data.FullData;
 import com.github.fge.msgsimple.bundle.MessageBundle;
+import com.github.fge.msgsimple.load.MessageBundles;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
@@ -52,6 +54,7 @@
 import static org.mockito.Mockito.mock;
 import static org.testng.Assert.assertEquals;
 import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.fail;
 
 public final class ValidationProcessorTest
 {
@@ -123,8 +126,18 @@ public void circularReferencingDuringValidationIsDetected()
             = JsonLoader.fromResource("/other/issue102.json");
         final JsonSchemaFactory factory = JsonSchemaFactory.byDefault();
         final JsonValidator validator = factory.getValidator();
-
-        validator.validate(schemaNode, JacksonUtils.nodeFactory().nullNode());
+        final MessageBundle bundle
+            = MessageBundles.getBundle(JsonSchemaValidationBundle.class);
+        final String expectedMsg
+            = bundle.getMessage("err.common.validationLoop");
+
+        try {
+            validator.validate(schemaNode,
+                JacksonUtils.nodeFactory().nullNode());
+            fail("No exception thrown!");
+        } catch (ProcessingException e) {
+            assertEquals(e.getMessage(), expectedMsg);
+        }
         assertTrue(true);
     }