Mark remaining test classes private (dropwizard#4273)

This is the last batch which Sonar is unhappy about.

Since JUnit 5, test classes and methods needn't be public

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/LayoutIntegrationTests.java

@@ -41,7 +41,7 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
-public class LayoutIntegrationTests {
+class LayoutIntegrationTests {
 
     static {
         BootstrapLogging.bootstrap(Level.INFO, new EventJsonLayoutBaseFactory());

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/layout/AccessJsonLayoutTest.java

@@ -21,7 +21,7 @@
 import static org.assertj.core.api.Assertions.entry;
 import static org.mockito.Mockito.when;
 
-public class AccessJsonLayoutTest {
+class AccessJsonLayoutTest {
 
     private String remoteHost = "nw-4.us.crawl.io";
     private String serverName = "sw-2.us.api.example.io";

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/layout/EventJsonLayoutTest.java

@@ -26,7 +26,7 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
-public class EventJsonLayoutTest {
+class EventJsonLayoutTest {
     private static final String timestamp = "2018-01-02T15:19:21.000+0000";
     private static final String logger = "com.example.user.service";
     private static final String message = "User[18] has been registered";

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/layout/ExceptionFormatTest.java

@@ -4,7 +4,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class ExceptionFormatTest {
+class ExceptionFormatTest {
 
     @Test
     void testDefaults() {

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/layout/JsonFormatterTest.java

@@ -13,7 +13,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class JsonFormatterTest {
+class JsonFormatterTest {
 
     private final SortedMap<String, Object> map = new TreeMap<>(Maps.of(
             "name", "Jim",

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/layout/MapBuilderTest.java

@@ -8,7 +8,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.entry;
 
-public class MapBuilderTest {
+class MapBuilderTest {
 
     private int size = 4;
     private TimestampFormatter timestampFormatter = new TimestampFormatter("yyyy-MM-dd'T'HH:mm:ss.SSSZ", ZoneId.of("UTC"));

dropwizard-json-logging/src/test/java/io/dropwizard/logging/json/layout/TimestampFormatterTest.java

@@ -6,7 +6,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class TimestampFormatterTest {
+class TimestampFormatterTest {
 
     private final long timestamp = 1513956631000L;
 

dropwizard-lifecycle/src/test/java/io/dropwizard/lifecycle/AutoCloseableManagerTest.java

@@ -5,7 +5,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class AutoCloseableManagerTest {
+class AutoCloseableManagerTest {
 
     private final AutoCloseable managed = mock(AutoCloseable.class);
     private final AutoCloseableManager closeableManager = new AutoCloseableManager(this.managed);

dropwizard-lifecycle/src/test/java/io/dropwizard/lifecycle/ExecutorServiceManagerTest.java

@@ -14,7 +14,7 @@
 
 import io.dropwizard.util.Duration;
 
-public class ExecutorServiceManagerTest {
+class ExecutorServiceManagerTest {
 
     private static final Duration TEST_DURATION = Duration.seconds(1L);
     private final ExecutorService exec = mock(ExecutorService.class);

dropwizard-lifecycle/src/test/java/io/dropwizard/lifecycle/JettyManagedTest.java

@@ -6,7 +6,7 @@
 import static org.mockito.Mockito.inOrder;
 import static org.mockito.Mockito.mock;
 
-public class JettyManagedTest {
+class JettyManagedTest {
     private final Managed managed = mock(Managed.class);
     private final JettyManaged jettyManaged = new JettyManaged(managed);
 

dropwizard-lifecycle/src/test/java/io/dropwizard/lifecycle/setup/LifecycleEnvironmentTest.java

@@ -19,7 +19,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 
-public class LifecycleEnvironmentTest {
+class LifecycleEnvironmentTest {
 
     private final LifecycleEnvironment environment = new LifecycleEnvironment(new MetricRegistry());
 

dropwizard-lifecycle/src/test/java/io/dropwizard/lifecycle/setup/ScheduledExecutorServiceBuilderTest.java

@@ -19,7 +19,7 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
-public class ScheduledExecutorServiceBuilderTest {
+class ScheduledExecutorServiceBuilderTest {
 
     private static final Duration DEFAULT_SHUTDOWN_PERIOD = Duration.seconds(5L);
 

dropwizard-logging/src/test/java/io/dropwizard/logging/AppenderFactoryCustomTimeZoneTest.java

@@ -20,7 +20,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class AppenderFactoryCustomTimeZoneTest {
+class AppenderFactoryCustomTimeZoneTest {
 
     static {
         BootstrapLogging.bootstrap();

dropwizard-logging/src/test/java/io/dropwizard/logging/ConsoleAppenderFactoryTest.java

@@ -14,7 +14,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class ConsoleAppenderFactoryTest {
+class ConsoleAppenderFactoryTest {
     static {
         BootstrapLogging.bootstrap();
     }

dropwizard-logging/src/test/java/io/dropwizard/logging/DefaultLoggingFactoryPrintErrorMessagesTest.java

@@ -22,7 +22,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
-public class DefaultLoggingFactoryPrintErrorMessagesTest {
+class DefaultLoggingFactoryPrintErrorMessagesTest {
     private DefaultLoggingFactory factory;
     private ByteArrayOutputStream output;
 

dropwizard-logging/src/test/java/io/dropwizard/logging/DefaultLoggingFactoryTest.java

@@ -35,7 +35,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class DefaultLoggingFactoryTest {
+class DefaultLoggingFactoryTest {
     private final ObjectMapper objectMapper = Jackson.newObjectMapper();
     private final YamlConfigurationFactory<DefaultLoggingFactory> factory = new YamlConfigurationFactory<>(
             DefaultLoggingFactory.class,

dropwizard-logging/src/test/java/io/dropwizard/logging/DropwizardLayoutTest.java

@@ -8,7 +8,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 
-public class DropwizardLayoutTest {
+class DropwizardLayoutTest {
     private final LoggerContext context = mock(LoggerContext.class);
     private final TimeZone timeZone = TimeZone.getTimeZone("UTC");
     private final DropwizardLayout layout = new DropwizardLayout(context, timeZone);

dropwizard-logging/src/test/java/io/dropwizard/logging/ExternalLoggingFactoryTest.java

@@ -11,7 +11,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class ExternalLoggingFactoryTest {
+class ExternalLoggingFactoryTest {
 
     @Test
     void canBeDeserialized() throws Exception {

dropwizard-logging/src/test/java/io/dropwizard/logging/PrefixedExtendedThrowableProxyConverterTest.java

@@ -9,7 +9,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class PrefixedExtendedThrowableProxyConverterTest {
+class PrefixedExtendedThrowableProxyConverterTest {
     private final PrefixedExtendedThrowableProxyConverter converter = new PrefixedExtendedThrowableProxyConverter();
     private final ThrowableProxy proxy = new ThrowableProxy(new IOException("noo"));
 

dropwizard-logging/src/test/java/io/dropwizard/logging/PrefixedRootCauseFirstThrowableProxyConverterTest.java

@@ -19,7 +19,7 @@
 /**
  * Tests {@link PrefixedRootCauseFirstThrowableProxyConverter}.
  */
-public class PrefixedRootCauseFirstThrowableProxyConverterTest {
+class PrefixedRootCauseFirstThrowableProxyConverterTest {
 
     private final PrefixedRootCauseFirstThrowableProxyConverter converter
             = new PrefixedRootCauseFirstThrowableProxyConverter();

dropwizard-logging/src/test/java/io/dropwizard/logging/PrefixedThrowableProxyConverterTest.java

@@ -9,7 +9,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class PrefixedThrowableProxyConverterTest {
+class PrefixedThrowableProxyConverterTest {
     private final PrefixedThrowableProxyConverter converter = new PrefixedThrowableProxyConverter();
     private final ThrowableProxy proxy = new ThrowableProxy(new IOException("noo"));
 

dropwizard-logging/src/test/java/io/dropwizard/logging/SyslogAppenderFactoryTest.java

@@ -18,7 +18,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatCode;
 
-public class SyslogAppenderFactoryTest {
+class SyslogAppenderFactoryTest {
 
     static {
         BootstrapLogging.bootstrap();

dropwizard-logging/src/test/java/io/dropwizard/logging/TlsSocketAppenderFactoryTest.java

@@ -25,7 +25,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class TlsSocketAppenderFactoryTest {
+class TlsSocketAppenderFactoryTest {
 
     public TcpServer tcpServer = new TcpServer(createServerSocket());
 

dropwizard-logging/src/test/java/io/dropwizard/logging/UdpSocketAppenderFactoryTest.java

@@ -23,7 +23,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.fail;
 
-public class UdpSocketAppenderFactoryTest {
+class UdpSocketAppenderFactoryTest {
 
     private static final int UDP_PORT = 32144;
 

dropwizard-logging/src/test/java/io/dropwizard/logging/socket/DropwizardUdpSocketAppenderTest.java

@@ -17,7 +17,7 @@
 import static java.nio.charset.StandardCharsets.UTF_8;
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class DropwizardUdpSocketAppenderTest {
+class DropwizardUdpSocketAppenderTest {
 
     private OutputStreamAppender<ILoggingEvent> udpStreamAppender;
 

dropwizard-metrics-graphite/src/test/java/io/dropwizard/metrics/graphite/GraphiteReporterFactoryTest.java

@@ -18,7 +18,7 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 
-public class GraphiteReporterFactoryTest {
+class GraphiteReporterFactoryTest {
 
     private final GraphiteReporter.Builder builderSpy = mock(GraphiteReporter.Builder.class);
 

dropwizard-metrics/src/test/java/io/dropwizard/metrics/BaseReporterFactoryTest.java

@@ -16,12 +16,12 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 
-public class BaseReporterFactoryTest {
+class BaseReporterFactoryTest {
     private static final Set<String> INCLUDES = Sets.of("inc", "both", "inc.+");
     private static final Set<String> EXCLUDES = Sets.of("exc", "both", "exc.+");
     private static final Set<String> EMPTY = Collections.emptySet();
 
-    public static Stream<Arguments> data() {
+    static Stream<Arguments> data() {
 
         return Stream.of(
                 /*
@@ -85,7 +85,7 @@ public ScheduledReporter build(MetricRegistry registry) {
 
     @ParameterizedTest
     @MethodSource("data")
-    public void testDefaultMatching(Set<String> includes, Set<String> excludes, String name,
+    void testDefaultMatching(Set<String> includes, Set<String> excludes, String name,
                                     boolean expectedDefaultResult, boolean expectedRegexResult,
                                     boolean expectedSubstringResult, String msg) {
         factory.setIncludes(includes);
@@ -100,7 +100,7 @@ public void testDefaultMatching(Set<String> includes, Set<String> excludes, Stri
 
     @ParameterizedTest
     @MethodSource("data")
-    public void testRegexMatching(Set<String> includes, Set<String> excludes, String name,
+    void testRegexMatching(Set<String> includes, Set<String> excludes, String name,
                                   boolean expectedDefaultResult, boolean expectedRegexResult,
                                   boolean expectedSubstringResult, String msg) {
         factory.setIncludes(includes);
@@ -115,7 +115,7 @@ public void testRegexMatching(Set<String> includes, Set<String> excludes, String
 
     @ParameterizedTest
     @MethodSource("data")
-    public void tesSubstringMatching(Set<String> includes, Set<String> excludes, String name,
+    void tesSubstringMatching(Set<String> includes, Set<String> excludes, String name,
                                      boolean expectedDefaultResult, boolean expectedRegexResult,
                                      boolean expectedSubstringResult, String msg) {
         factory.setIncludes(includes);

dropwizard-metrics/src/test/java/io/dropwizard/metrics/ConsoleReporterFactoryTest.java

@@ -5,7 +5,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class ConsoleReporterFactoryTest {
+class ConsoleReporterFactoryTest {
     @Test
     void isDiscoverable() throws Exception {
         assertThat(new DiscoverableSubtypeResolver().getDiscoveredSubtypes())

dropwizard-metrics/src/test/java/io/dropwizard/metrics/CsvReporterFactoryTest.java

@@ -15,7 +15,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class CsvReporterFactoryTest {
+class CsvReporterFactoryTest {
     private final ObjectMapper objectMapper = Jackson.newObjectMapper();
     private final YamlConfigurationFactory<MetricsFactory> factory =
             new YamlConfigurationFactory<>(MetricsFactory.class,

dropwizard-metrics/src/test/java/io/dropwizard/metrics/MetricAttributesTest.java

@@ -12,7 +12,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class MetricAttributesTest {
+class MetricAttributesTest {
 
     private static final EnumSet<MetricAttribute> ALL = EnumSet.allOf(MetricAttribute.class);
     private static final EnumSet<MetricAttribute> NONE = EnumSet.noneOf(MetricAttribute.class);
@@ -36,7 +36,7 @@ public ScheduledReporter build(MetricRegistry registry) {
 
     @ParameterizedTest
     @MethodSource("data")
-    public void testGetDisabledAttributes(EnumSet<MetricAttribute> includes, EnumSet<MetricAttribute> excludes,
+    void testGetDisabledAttributes(EnumSet<MetricAttribute> includes, EnumSet<MetricAttribute> excludes,
                                           EnumSet<MetricAttribute> expectedResult) {
         factory.setIncludesAttributes(includes);
         factory.setExcludesAttributes(excludes);

dropwizard-metrics/src/test/java/io/dropwizard/metrics/MetricsFactoryTest.java

@@ -16,7 +16,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class MetricsFactoryTest {
+class MetricsFactoryTest {
     static {
         BootstrapLogging.bootstrap();
     }

dropwizard-metrics/src/test/java/io/dropwizard/metrics/ScheduledReporterManagerTest.java

@@ -10,7 +10,7 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 
-public class ScheduledReporterManagerTest {
+class ScheduledReporterManagerTest {
 
     @Test
     void testStopWithoutReporting() throws Exception {

dropwizard-metrics/src/test/java/io/dropwizard/metrics/Slf4jReporterFactoryTest.java

@@ -5,7 +5,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class Slf4jReporterFactoryTest {
+class Slf4jReporterFactoryTest {
     @Test
     void isDiscoverable() throws Exception {
         assertThat(new DiscoverableSubtypeResolver().getDiscoveredSubtypes())

dropwizard-migrations/src/test/java/io/dropwizard/migrations/AbstractMigrationTest.java

@@ -10,7 +10,7 @@
 import java.sql.SQLException;
 import java.util.UUID;
 
-public class AbstractMigrationTest {
+class AbstractMigrationTest {
 
     static {
         SqlGeneratorFactory.getInstance().unregister(AddColumnGeneratorSQLite.class);

dropwizard-migrations/src/test/java/io/dropwizard/migrations/CloseableLiquibaseTest.java

@@ -11,7 +11,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @NotThreadSafe
-public class CloseableLiquibaseTest {
+class CloseableLiquibaseTest {
 
     CloseableLiquibase liquibase;
     ManagedPooledDataSource dataSource;

dropwizard-migrations/src/test/java/io/dropwizard/migrations/DbCalculateChecksumCommandTest.java

@@ -16,7 +16,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @NotThreadSafe
-public class DbCalculateChecksumCommandTest extends AbstractMigrationTest {
+class DbCalculateChecksumCommandTest extends AbstractMigrationTest {
 
     private final DbCalculateChecksumCommand<TestMigrationConfiguration> migrateCommand = new DbCalculateChecksumCommand<>(
         TestMigrationConfiguration::getDataSource, TestMigrationConfiguration.class, "migrations.xml");

dropwizard-migrations/src/test/java/io/dropwizard/migrations/DbClearChecksumsCommandTest.java

@@ -15,7 +15,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @NotThreadSafe
-public class DbClearChecksumsCommandTest extends AbstractMigrationTest {
+class DbClearChecksumsCommandTest extends AbstractMigrationTest {
 
     private final DbClearChecksumsCommand<TestMigrationConfiguration> clearChecksums = new DbClearChecksumsCommand<>(
         TestMigrationConfiguration::getDataSource, TestMigrationConfiguration.class, "migrations.xml");

dropwizard-migrations/src/test/java/io/dropwizard/migrations/DbDumpCommandTest.java

@@ -32,7 +32,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @NotThreadSafe
-public class DbDumpCommandTest extends AbstractMigrationTest {
+class DbDumpCommandTest extends AbstractMigrationTest {
 
     private static final List<String> ATTRIBUTE_NAMES = Arrays.asList("columns", "foreign-keys", "indexes",
             "primary-keys", "sequences", "tables", "unique-constraints", "views");

dropwizard-migrations/src/test/java/io/dropwizard/migrations/DbGenerateDocsCommandTest.java

@@ -15,7 +15,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @NotThreadSafe
-public class DbGenerateDocsCommandTest extends AbstractMigrationTest {
+class DbGenerateDocsCommandTest extends AbstractMigrationTest {
 
     private final DbGenerateDocsCommand<TestMigrationConfiguration> generateDocsCommand = new DbGenerateDocsCommand<>(
         TestMigrationConfiguration::getDataSource, TestMigrationConfiguration.class, "migrations.xml");