Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/1994 max fee per gas check #2073

Open
wants to merge 8 commits into
base: v4.0.0
Choose a base branch
from
Open

Bug/1994 max fee per gas check #2073

wants to merge 8 commits into from

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Jan 10, 2025 •
edited
Loading

fixes #1994

added patch timestamp MaxFeePerGasPatchTimestamp to add m_maxPriorityFeePerGas > m_maxFeePerGas check
in this case transaction should not be included to the pending transactions queue and Invalid transaction format error should be thrown

added MaxFeePerGasPatchTimestamp check when a transaction is added to the transaction queue or to the blockchain or is read from the database

added unit test JsonRpcSuite/maxFeePerGasPatch

no performance impact

@olehnikolaiev olehnikolaiev linked an issue Jan 14, 2025 that may be closed by this pull request
"maxFeePerGas" may be lower than maxPriorityFeePerGas #1994
Open
@DmytroNazarenko DmytroNazarenko added this to the SKALE 4.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SKALE 4.0
Development

Successfully merging this pull request may close these issues.

"maxFeePerGas" may be lower than maxPriorityFeePerGas
2 participants
@olehnikolaiev @DmytroNazarenko