forked from twitter/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
pants_plugin
and contrib_plugin
targets.
These targets support easy adoption of pants own plugin entry_points to allow for one less step when installing pants plugins. The existing plugins are converted to use these targets and the contrib README is updated to reflect the new best-practice boilerplate. Testing Done: Tested that the re-vamped plugin install tests that use the new entry_points worked via: `./build-support/bin/release.sh -n` CI went green here: https://travis-ci.org/pantsbuild/pants/builds/75535801 Bugs closed: 1967, 1968 Reviewed at https://rbcommons.com/s/twitter/r/2615/
- Loading branch information
Showing
12 changed files
with
177 additions
and
83 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,17 @@ | ||
# Copyright 2015 Pants project contributors (see CONTRIBUTORS.md). | ||
# Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
||
python_library( | ||
contrib_plugin( | ||
name='plugin', | ||
sources=['register.py'], | ||
dependencies=[ | ||
'contrib/cpp/src/python/pants/contrib/cpp/targets:targets', | ||
'contrib/cpp/src/python/pants/contrib/cpp/tasks:tasks', | ||
'contrib/cpp/src/python/pants/contrib/cpp/toolchain:toolchain', | ||
'src/python/pants/base:build_file_aliases', | ||
'src/python/pants/goal:task_registrar', | ||
], | ||
provides=contrib_setup_py( | ||
name='pantsbuild.pants.contrib.cpp', | ||
description='C++ pants plugin.', | ||
), | ||
distribution_name='pantsbuild.pants.contrib.cpp', | ||
description='C++ pants plugin.', | ||
build_file_aliases=True, | ||
register_goals=True, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,16 @@ | ||
# Copyright 2015 Pants project contributors (see CONTRIBUTORS.md). | ||
# Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
||
python_library( | ||
contrib_plugin( | ||
name='plugin', | ||
sources=['register.py'], | ||
dependencies=[ | ||
'contrib/go/src/python/pants/contrib/go/targets', | ||
'contrib/go/src/python/pants/contrib/go/tasks', | ||
'src/python/pants/base:build_file_aliases', | ||
'src/python/pants/goal:task_registrar', | ||
], | ||
provides=contrib_setup_py( | ||
name='pantsbuild.pants.contrib.go', | ||
description='Go language support for pants.', | ||
) | ||
distribution_name='pantsbuild.pants.contrib.go', | ||
description='Go language support for pants.', | ||
build_file_aliases=True, | ||
register_goals=True, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,16 @@ | ||
# Copyright 2015 Pants project contributors (see CONTRIBUTORS.md). | ||
# Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
||
python_library( | ||
contrib_plugin( | ||
name='plugin', | ||
sources=['register.py'], | ||
dependencies=[ | ||
'contrib/scrooge/src/python/pants/contrib/scrooge/tasks', | ||
'src/python/pants/goal:task_registrar', | ||
], | ||
provides=contrib_setup_py( | ||
name='pantsbuild.pants.contrib.scrooge', | ||
description='Scrooge thrift generator pants plugins.', | ||
additional_classifiers=[ | ||
'Topic :: Software Development :: Code Generators' | ||
] | ||
) | ||
distribution_name='pantsbuild.pants.contrib.scrooge', | ||
description='Scrooge thrift generator pants plugins.', | ||
additional_classifiers=[ | ||
'Topic :: Software Development :: Code Generators' | ||
], | ||
register_goals=True, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,19 @@ | ||
# Copyright 2015 Pants project contributors (see CONTRIBUTORS.md). | ||
# Licensed under the Apache License, Version 2.0 (see LICENSE). | ||
|
||
python_library( | ||
contrib_plugin( | ||
name='plugin', | ||
sources=['register.py'], | ||
dependencies=[ | ||
'contrib/spindle/src/python/pants/contrib/spindle/targets', | ||
'contrib/spindle/src/python/pants/contrib/spindle/tasks', | ||
'src/python/pants/base:build_file_aliases', | ||
'src/python/pants/goal:task_registrar', | ||
], | ||
provides=contrib_setup_py( | ||
name='pantsbuild.pants.contrib.spindle', | ||
description='Spindle thrift -> scala generator pants plugins.', | ||
additional_classifiers=[ | ||
'Topic :: Software Development :: Code Generators' | ||
] | ||
) | ||
distribution_name='pantsbuild.pants.contrib.spindle', | ||
description='Spindle thrift -> scala generator pants plugins.', | ||
additional_classifiers=[ | ||
'Topic :: Software Development :: Code Generators' | ||
], | ||
build_file_aliases=True, | ||
register_goals=True, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.