remove unused imports

Testing Done:
CI passes: https://travis-ci.org/pantsbuild/pants/builds/73626291

Bugs closed: 1905, pantsbuild#1902

Reviewed at https://rbcommons.com/s/twitter/r/2556/

contrib/cpp/src/python/pants/contrib/cpp/tasks/BUILD

@@ -17,6 +17,5 @@ python_library(
     'src/python/pants/backend/core/tasks:common',
     'src/python/pants/base:exceptions',
     'src/python/pants/base:workunit',
-    'src/python/pants/util:dirutil',
   ],
 )

contrib/cpp/src/python/pants/contrib/cpp/tasks/cpp_compile.py

@@ -9,7 +9,6 @@
 
 from pants.base.build_environment import get_buildroot
 from pants.base.workunit import WorkUnit
-from pants.util.dirutil import safe_mkdir
 
 from pants.contrib.cpp.tasks.cpp_task import CppTask
 

contrib/cpp/src/python/pants/contrib/cpp/tasks/cpp_library_create.py

@@ -8,7 +8,6 @@
 import os
 
 from pants.base.workunit import WorkUnit
-from pants.util.dirutil import safe_mkdir
 
 from pants.contrib.cpp.tasks.cpp_task import CppTask
 

contrib/cpp/src/python/pants/contrib/cpp/tasks/cpp_run.py

@@ -5,8 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import os
-
 from pants.base.workunit import WorkUnit
 
 from pants.contrib.cpp.targets.cpp_binary import CppBinary

contrib/scrooge/src/python/pants/contrib/scrooge/tasks/BUILD

@@ -35,7 +35,6 @@ python_library(
   name='thrift_linter',
   sources=['thrift_linter.py'],
   dependencies=[
-    'src/python/pants/backend/jvm/tasks:jvm_tool_task_mixin',
     'src/python/pants/backend/jvm/tasks:nailgun_task',
     'src/python/pants/base:exceptions',
     'src/python/pants/base:workunit',

contrib/scrooge/src/python/pants/contrib/scrooge/tasks/thrift_linter.py

@@ -5,7 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-from pants.backend.jvm.tasks.jvm_tool_task_mixin import JvmToolTaskMixin
 from pants.backend.jvm.tasks.nailgun_task import NailgunTask
 from pants.base.exceptions import TaskError
 from pants.base.workunit import WorkUnit

contrib/spindle/tests/python/pants_test/contrib/spindle/tasks/test_spindle_gen.py

@@ -10,9 +10,7 @@
 
 from pants.backend.jvm.targets.jar_dependency import JarDependency
 from pants.backend.jvm.targets.jar_library import JarLibrary
-from pants.backend.jvm.targets.scala_library import ScalaLibrary
 from pants.base.build_file_aliases import BuildFileAliases
-from pants.goal.context import Context
 from pants_test.jvm.jvm_tool_task_test_base import JvmToolTaskTestBase
 
 from pants.contrib.spindle.targets.spindle_thrift_library import SpindleThriftLibrary

src/python/pants/backend/core/tasks/BUILD

@@ -333,7 +333,6 @@ python_library(
     'src/python/pants/cache',
     'src/python/pants/ivy',
     'src/python/pants/java:executor',
-    'src/python/pants/option',
     'src/python/pants/reporting',
     'src/python/pants/util:meta',
   ],

src/python/pants/backend/core/tasks/task.py

@@ -22,7 +22,6 @@
 from pants.cache.artifact_cache import UnreadableArtifact, call_insert, call_use_cached_files
 from pants.cache.cache_setup import CacheSetup
 from pants.option.optionable import Optionable
-from pants.option.options import Options
 from pants.option.options_fingerprinter import OptionsFingerprinter
 from pants.option.scope import ScopeInfo
 from pants.reporting.reporting_utils import items_to_report_element

src/python/pants/backend/jvm/tasks/BUILD

@@ -196,9 +196,7 @@ python_library(
     ':jar_task',
     'src/python/pants/base:exceptions',
     'src/python/pants/base:workunit',
-    'src/python/pants/fs',
     'src/python/pants/backend/jvm/targets:jvm',
-    'src/python/pants/util:dirutil',
   ],
 )
 
@@ -430,8 +428,7 @@ python_library(
   sources = ['scalastyle.py'],
   dependencies = [
     ':nailgun_task',
-    'src/python/pants/backend/core/tasks:task',
-    'src/python/pants/base:cache_manager',
+    'src/python/pants/base:exceptions',
     'src/python/pants/base:target',
     'src/python/pants/process',
     'src/python/pants/util:dirutil'

src/python/pants/backend/jvm/tasks/jar_create.py

@@ -12,8 +12,6 @@
 from pants.backend.jvm.tasks.jar_task import JarTask
 from pants.base.exceptions import TaskError
 from pants.base.workunit import WorkUnit
-from pants.fs.fs import safe_filename
-from pants.util.dirutil import safe_mkdir
 
 
 def is_jvm_binary(target):

src/python/pants/backend/jvm/tasks/jvm_compile/scala/scala_compile.py

@@ -11,7 +11,6 @@
 from xml.etree import ElementTree
 
 from pants.backend.jvm.subsystems.scala_platform import ScalaPlatform
-from pants.backend.jvm.targets.jar_library import JarLibrary
 from pants.backend.jvm.tasks.jvm_compile.analysis_tools import AnalysisTools
 from pants.backend.jvm.tasks.jvm_compile.jvm_compile import JvmCompile
 from pants.backend.jvm.tasks.jvm_compile.scala.zinc_analysis import ZincAnalysis

src/python/pants/backend/jvm/tasks/scalastyle.py

@@ -8,9 +8,7 @@
 import os
 import re
 
-from pants.backend.jvm.tasks.jvm_tool_task_mixin import JvmToolTaskMixin
 from pants.backend.jvm.tasks.nailgun_task import NailgunTask
-from pants.base.cache_manager import VersionedTargetSet
 from pants.base.exceptions import TaskError
 from pants.base.target import Target
 from pants.process.xargs import Xargs

src/python/pants/backend/project_info/tasks/BUILD

@@ -32,14 +32,8 @@ python_library(
   name = 'depmap',
   sources = ['depmap.py'],
   dependencies = [
-    '3rdparty/python/twitter/commons:twitter.common.collections',
-    'src/python/pants/backend/core/targets:all',
     'src/python/pants/backend/core/tasks:console_task',
     'src/python/pants/backend/jvm/targets:jvm',
-    'src/python/pants/backend/jvm/targets:scala',
-    'src/python/pants/backend/jvm:ivy_utils',
-    'src/python/pants/base:build_environment',
-    'src/python/pants/base:deprecated',
     'src/python/pants/base:exceptions',
   ],
 )

src/python/pants/backend/project_info/tasks/depmap.py

@@ -5,21 +5,8 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import json
-import os
-from collections import defaultdict
-
-from twitter.common.collections import OrderedSet
-
-from pants.backend.core.targets.resources import Resources
 from pants.backend.core.tasks.console_task import ConsoleTask
-from pants.backend.jvm.ivy_utils import IvyModuleRef
 from pants.backend.jvm.targets.jar_dependency import JarDependency
-from pants.backend.jvm.targets.jar_library import JarLibrary
-from pants.backend.jvm.targets.jvm_app import JvmApp
-from pants.backend.jvm.targets.scala_library import ScalaLibrary
-from pants.base.build_environment import get_buildroot
-from pants.base.deprecated import deprecated
 from pants.base.exceptions import TaskError
 
 

src/python/pants/base/BUILD

@@ -302,7 +302,6 @@ python_library(
   dependencies = [
     '3rdparty/python:six',
     ':addressable',
-    ':deprecated',
     ':exceptions',
   ],
 )

src/python/pants/base/cache_manager.py

@@ -13,12 +13,6 @@
 from pants.util.dirutil import safe_mkdir
 
 
-try:
-  import cPickle as pickle
-except ImportError:
-  import pickle
-
-
 class VersionedTargetSet(object):
   """Represents a list of targets, a corresponding CacheKey, and a flag determining whether the
   list of targets is currently valid.

src/python/pants/base/target_addressable.py

@@ -8,7 +8,6 @@
 from six import string_types
 
 from pants.base.addressable import Addressable
-from pants.base.deprecated import deprecated
 from pants.base.exceptions import TargetDefinitionException
 
 

src/python/pants/goal/BUILD

@@ -32,7 +32,6 @@ python_library(
   dependencies = [
     ':products',
     ':workspace',
-    'src/python/pants/base:address',
     'src/python/pants/base:build_environment',
     'src/python/pants/base:build_graph',
     'src/python/pants/base:source_root',

src/python/pants/goal/context.py

@@ -12,7 +12,6 @@
 
 from twitter.common.collections import OrderedSet
 
-from pants.base.address import SyntheticAddress
 from pants.base.build_environment import get_buildroot, get_scm
 from pants.base.build_graph import BuildGraph
 from pants.base.source_root import SourceRoot

src/python/pants/goal/goal.py

@@ -6,7 +6,6 @@
                         unicode_literals, with_statement)
 
 from pants.goal.error import GoalError
-from pants.option.scope import ScopeInfo
 
 
 class Goal(object):

src/python/pants/java/nailgun_executor.py

@@ -12,7 +12,6 @@
 import select
 import threading
 import time
-from collections import namedtuple
 
 from six import string_types
 from twitter.common.collections import maybe_list

src/python/pants/java/util.py

@@ -5,8 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import os
-
 from pants.base.workunit import WorkUnit
 from pants.java.executor import Executor, SubprocessExecutor
 from pants.java.nailgun_executor import NailgunExecutor

src/python/pants/option/options_fingerprinter.py

@@ -6,7 +6,6 @@
                         unicode_literals, with_statement)
 
 import json
-import os
 from hashlib import sha1
 
 from pants.option.options import Options

src/python/pants/reporting/reporting_server.py

@@ -25,7 +25,6 @@
 from pants.base.mustache import MustacheRenderer
 from pants.base.run_info import RunInfo
 from pants.pantsd.process_manager import ProcessManager
-from pants.util.dirutil import safe_delete, safe_mkdir
 
 
 logger = logging.getLogger(__name__)

src/python/pants/util/filtering.py

@@ -5,7 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import copy
 import operator
 
 

tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_java_zinc_compile_integration.py

@@ -5,8 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import unittest
-
 from pants.util.contextutil import temporary_dir
 from pants_test.backend.jvm.tasks.jvm_compile.base_compile_integration_test import BaseCompileIT
 from pants_test.testutils.compile_strategy_utils import provide_compile_strategies

tests/python/pants_test/backend/jvm/tasks/jvm_compile/java/test_java_zinc_compile_jvm_platform_integration.py

@@ -5,8 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import pytest
-
 from pants_test.backend.jvm.tasks.jvm_compile.java.jvm_platform_integration_mixin import \
   JvmPlatformIntegrationMixin
 from pants_test.pants_run_integration_test import PantsRunIntegrationTest

tests/python/pants_test/backend/jvm/tasks/test_ivy_resolve.py

@@ -11,7 +11,7 @@
 from twitter.common.collections import OrderedSet
 
 from pants.backend.jvm.ivy_utils import IvyArtifact as IvyUtilArtifact
-from pants.backend.jvm.ivy_utils import IvyInfo, IvyModule, IvyModuleRef, IvyUtils
+from pants.backend.jvm.ivy_utils import IvyInfo, IvyModule, IvyModuleRef
 from pants.backend.jvm.targets.exclude import Exclude
 from pants.backend.jvm.targets.jar_dependency import IvyArtifact, JarDependency
 from pants.backend.jvm.targets.jar_library import JarLibrary

tests/python/pants_test/backend/project_info/tasks/BUILD

@@ -34,15 +34,9 @@ python_tests(
   coverage = ['pants.backend.project_info.tasks.depmap'],
   dependencies = [
     'src/python/pants/backend/core:plugin',
-    'src/python/pants/backend/core/targets:common',
     'src/python/pants/backend/jvm:plugin',
-    'src/python/pants/backend/jvm/targets:java',
-    'src/python/pants/backend/jvm/targets:jvm',
-    'src/python/pants/backend/jvm/targets:scala',
     'src/python/pants/backend/project_info/tasks:depmap',
     'src/python/pants/backend/python:plugin',
-    'src/python/pants/base:build_file_aliases',
-    'src/python/pants/base:exceptions',
     'tests/python/pants_test/tasks:task_test_base',
   ]
 )

tests/python/pants_test/backend/project_info/tasks/test_depmap.py

@@ -5,25 +5,12 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import json
-import os
 from textwrap import dedent
 
 from pants.backend.core.register import build_file_aliases as register_core
-from pants.backend.core.targets.dependencies import Dependencies
-from pants.backend.core.targets.resources import Resources
 from pants.backend.jvm.register import build_file_aliases as register_jvm
-from pants.backend.jvm.targets.jar_dependency import JarDependency
-from pants.backend.jvm.targets.jar_library import JarLibrary
-from pants.backend.jvm.targets.java_library import JavaLibrary
-from pants.backend.jvm.targets.java_tests import JavaTests
-from pants.backend.jvm.targets.jvm_app import JvmApp
-from pants.backend.jvm.targets.jvm_binary import JvmBinary
-from pants.backend.jvm.targets.jvm_target import JvmTarget
-from pants.backend.jvm.targets.scala_library import ScalaLibrary
 from pants.backend.project_info.tasks.depmap import Depmap
 from pants.backend.python.register import build_file_aliases as register_python
-from pants.base.exceptions import TaskError
 from pants_test.tasks.task_test_base import ConsoleTaskTestBase
 
 

tests/python/pants_test/base/BUILD

@@ -287,7 +287,6 @@ python_tests(
     'src/python/pants/backend/core',
     'src/python/pants/backend/jvm/targets:jvm',
     'src/python/pants/backend/python:python_requirement',
-    'src/python/pants/base:payload',
     'src/python/pants/base:payload_field',
     'tests/python/pants_test:base_test',
   ]
@@ -341,7 +340,6 @@ python_tests(
   dependencies = [
     '3rdparty/python/twitter/commons:twitter.common.collections',
     'src/python/pants/base:address',
-    'src/python/pants/base:addressable',
     'src/python/pants/base:source_root',
     'src/python/pants/base:target',
     ]

tests/python/pants_test/base/test_payload_field.py

@@ -10,7 +10,6 @@
 from pants.backend.jvm.targets.exclude import Exclude
 from pants.backend.jvm.targets.jar_dependency import IvyArtifact, JarDependency
 from pants.backend.python.python_requirement import PythonRequirement
-from pants.base.payload import Payload
 from pants.base.payload_field import (ExcludesField, FingerprintedField, FingerprintedMixin,
                                       JarsField, PrimitiveField, PythonRequirementsField,
                                       SourcesField)

tests/python/pants_test/base/test_source_root.py

@@ -11,7 +11,6 @@
 from twitter.common.collections import OrderedSet
 
 from pants.base.address import SyntheticAddress, parse_spec
-from pants.base.addressable import AddressableCallProxy
 from pants.base.exceptions import TargetDefinitionException
 from pants.base.source_root import SourceRoot, SourceRootTree
 from pants.base.target import Target

tests/python/pants_test/option/test_options_fingerprinter.py

@@ -5,8 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-import unittest
-
 from pants.base.payload import Payload
 from pants.base.payload_field import PrimitiveField
 from pants.option.options import Options

tests/python/pants_test/pantsd/test_process_manager.py

@@ -8,7 +8,6 @@
 import os
 import subprocess
 import unittest
-from collections import namedtuple
 from contextlib import contextmanager
 
 import mock

tests/python/pants_test/tasks/test_filter.py

@@ -7,8 +7,6 @@
 
 from textwrap import dedent
 
-import pytest
-
 from pants.backend.core.targets.dependencies import Dependencies
 from pants.backend.core.targets.doc import Page
 from pants.backend.core.tasks.filter import Filter

tests/python/pants_test/tasks/test_junit_tests_integration.py

@@ -6,7 +6,6 @@
                         unicode_literals, with_statement)
 
 import os
-import unittest
 from xml.etree import ElementTree
 
 from pants.util.contextutil import temporary_dir

tests/python/pants_test/tasks/test_scalastyle_integration.py

@@ -5,8 +5,6 @@
 from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                         unicode_literals, with_statement)
 
-from contextlib import contextmanager
-
 from pants.util.contextutil import temporary_dir
 from pants_test.pants_run_integration_test import PantsRunIntegrationTest