forked from twitter/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "add a lint to warn on implicit string concatenation (pantsbui…
…ld#7286)" (pantsbuild#7340) This reverts commit 3a81e86. ### Problem The use of the `asttokens` library, now within the pythonstyle checker pex, is causing a variant of pantsbuild#7158 when consumed outside of this repo. Additionally, some files fail to parse with: ``` for tok in tokenize.generate_tokens(StringIO(str_node_text).readline): File "/opt/ee/python/2.7/lib/python2.7/tokenize.py", line 374, in generate_tokens ("<tokenize>", lnum, pos, line)) File "<tokenize>", line 3 "else echo 'no_op'; fi)" ``` Suppressing the lint only works if the lint runs without error, so this makes it impossible to consume outside of the pants repo right now (or at least, impossible in a lot of repos outside of the pants repo). ### Solution - Revert pantsbuild#7286. ### Result This will be unreverted asap when the above issues are investigated and fixed.
- Loading branch information
1 parent
646699b
commit e65723a
Showing
7 changed files
with
0 additions
and
94 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 0 additions & 56 deletions
56
...ib/python/src/python/pants/contrib/python/checks/checker/implicit_string_concatenation.py
This file was deleted.
Oops, something went wrong.
28 changes: 0 additions & 28 deletions
28
...sts/python/pants_test/contrib/python/checks/checker/test_implicit_string_concatenation.py
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters