Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use print() function in Python 2 and Python 3 #4

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 22, 2018

Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

Impacket's Python 3 branch is looking promising...

Legacy __print__ statements are syntax errors in Python 3 but __print()__ function works as expected in both Python 2 and Python 3.

Impacket's Python 3 branch is looking promising... https://github.com/SecureAuthCorp/impacket/tree/python36
@skorov skorov merged commit e15a6ba into skorov:master Dec 22, 2018
@cclauss cclauss deleted the patch-1 branch December 22, 2018 21:42
@skorov
Copy link
Owner

skorov commented Dec 22, 2018

Hey @cclauss thanks for the PR, mate! Definitely something I should have done initially. Once impacket is fully Python 3, I'll rework the entire project to fit that.

Thanks again. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants