Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network resets2 #74

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Network resets2 #74

merged 4 commits into from
Jan 8, 2024

Conversation

skot
Copy link
Owner

@skot skot commented Dec 29, 2023

This change handles two Stratum URL error modes that used to cause us to get into a reboot loop;

  • DNS lookup fails
  • DNS lookup works, but connect() fails

@skot skot requested a review from johnny9 December 29, 2023 05:00
@skot skot self-assigned this Dec 29, 2023
Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code and any comments that are redundant/obvious with the next line of code.

"Fixes #55" can be added to the body of the commit message and helps with tracking when issues are solved.

@johnny9
Copy link
Collaborator

johnny9 commented Dec 29, 2023

Recommend squashing the commits

@benjamin-wilson
Copy link
Collaborator

Recommend squashing the commits

You can always squash on the merge. GitHub has a nice big button for this.

@johnny9 johnny9 self-requested a review December 29, 2023 15:00
@johnny9
Copy link
Collaborator

johnny9 commented Dec 29, 2023

merge commits aren't great either. Its better to squash manually.

@skot
Copy link
Owner Author

skot commented Dec 29, 2023

My git skillz are low. How do I do this again?

@marsmensch
Copy link

@skot I assume johnny9 means rebasing all feature related commits this way:
https://www.freecodecamp.org/news/git-squash-commits/
Screenshot 2024-01-03 at 21 26 22
Screenshot 2024-01-03 at 21 26 57

@skot
Copy link
Owner Author

skot commented Jan 4, 2024

@skot I assume johnny9 means rebasing all feature related commits this way:

https://www.freecodecamp.org/news/git-squash-commits/

Screenshot 2024-01-03 at 21 26 22

Screenshot 2024-01-03 at 21 26 57

perfect, thanks! I'll give this a try

@skot skot merged commit dade418 into master Jan 8, 2024
2 checks passed
@AxisRay
Copy link

AxisRay commented Jan 8, 2024

https://github.com/espressif/esp-idf/tree/482a8fb2d78e3b58eb21b26da8a5bedf90623213/components/tcp_transport

I just found out that there’s already a TCP transport layer implementation in ESP-IDF. It encapsulates TCP, TLS, WebSocket, and also implements DNS functionality.

aaron3481 pushed a commit to aaron3481/ESP-Miner that referenced this pull request Jun 11, 2024
Fixes skot#55
* added error log message and retry when stratum can't connect
* handle dns_gethostbyname() failures
@skot skot deleted the network_resets2 branch August 16, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants