-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network resets2 #74
Network resets2 #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented out code and any comments that are redundant/obvious with the next line of code.
"Fixes #55" can be added to the body of the commit message and helps with tracking when issues are solved.
Recommend squashing the commits |
You can always squash on the merge. GitHub has a nice big button for this. |
merge commits aren't great either. Its better to squash manually. |
My git skillz are low. How do I do this again? |
@skot I assume johnny9 means rebasing all feature related commits this way: |
perfect, thanks! I'll give this a try |
I just found out that there’s already a TCP transport layer implementation in ESP-IDF. It encapsulates TCP, TLS, WebSocket, and also implements DNS functionality. |
Fixes skot#55 * added error log message and retry when stratum can't connect * handle dns_gethostbyname() failures
This change handles two Stratum URL error modes that used to cause us to get into a reboot loop;