client: implement callback protocols #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
Jul 14, 2021
There was a problem hiding this comment.
Thank you so much for the PR, @isidentical. Callback looks great, I should be able to support tqdm progress bars in the CLI here. Comments are inlined.
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 3248 3271 +23
Branches 187 188 +1
=========================================
+ Hits 3248 3271 +23
Continue to review full report at Codecov.
|
isidentical
force-pushed
the
fsspec-callbacks
branch
2 times, most recently
from
73147c9 to
8a54ee2
Compare
skshetry
reviewed
Jul 15, 2021
isidentical
force-pushed
the
fsspec-callbacks
branch
from
8a54ee2 to
cb52396
Compare
skshetry
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for the callbacks in the underlying client, so that when
put_file()is used it will pass thecallbackwithin it's**kwargsand it will just work like normal. I wasn't sure about deprecation policy, so supporting for both of the callback options required a bit of typing magic (casts), hopefully it is OK.